Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 846373002: Move l10n_util's GetCanonicalLocal() function into base/i18n module. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, tony
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move l10n_util's GetCanonicalLocal() function into base/i18n module. This removes the base version that takes const char*, and replace it by the one that takes const std::string&. Consolidating this code in one place and having a single function, instead of two with the same name in two different places. This is a redo of a patch that started in https://codereview.chromium.org/269943004/ and of another try that was made in https://codereview.chromium.org/834183005/. BUG=None TEST=base_unittests, ui_base_unittests and chrome. R=sky@chromium.org,thakis@chromium.org Committed: https://crrev.com/70dff4fc82ac26c9beecc54644ab7ee055596862 Cr-Commit-Position: refs/heads/master@{#311781}

Patch Set 1 #

Patch Set 2 : fix chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M base/i18n/rtl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
tfarina
PTAL
5 years, 11 months ago (2015-01-14 13:25:36 UTC) #1
tfarina
Scott, could you please take another look? I have fixed the chromeos error!
5 years, 11 months ago (2015-01-15 15:55:06 UTC) #2
sky
You need a base owner to review first.
5 years, 11 months ago (2015-01-15 18:35:10 UTC) #3
Nico
the cl description sounds like you're adding another function to base, but you're only changing ...
5 years, 11 months ago (2015-01-15 19:32:10 UTC) #4
Nico
On 2015/01/15 19:32:10, Nico wrote: > the cl description sounds like you're adding another function ...
5 years, 11 months ago (2015-01-15 19:32:26 UTC) #5
tfarina
CL description updated.
5 years, 11 months ago (2015-01-15 21:26:01 UTC) #6
Nico
lgtm
5 years, 11 months ago (2015-01-15 21:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846373002/20001
5 years, 11 months ago (2015-01-15 23:39:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:37:42 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:38:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70dff4fc82ac26c9beecc54644ab7ee055596862
Cr-Commit-Position: refs/heads/master@{#311781}

Powered by Google App Engine
This is Rietveld 408576698