base/i18n/rtl.cc - Issue 846373002: Move l10n_util's GetCanonicalLocal() function into base/i18n module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/rtl.cc

Issue 846373002: Move l10n_util's GetCanonicalLocal() function into base/i18n module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromeos Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/i18n/rtl.cc

diff --git a/base/i18n/rtl.cc b/base/i18n/rtl.cc

index 392cb13bdb78c112be17c8ee2c17ee69faf2d0fb..1cccae289375f92495963cee7bbc9341167a8a48 100644

--- a/base/i18n/rtl.cc

+++ b/base/i18n/rtl.cc

@@ -74,8 +74,8 @@ std::string GetConfiguredLocale() {

}

// Convert the ICU canonicalized locale to a string.

-std::string GetCanonicalLocale(const char* locale) {

- return GetLocaleString(icu::Locale::createCanonical(locale));

+std::string GetCanonicalLocale(const std::string& locale) {

+ return GetLocaleString(icu::Locale::createCanonical(locale.c_str()));

}

// Convert Chrome locale name to ICU locale name

« no previous file with comments | « base/i18n/rtl.h ('k') | chrome/browser/chromeos/customization/customization_document.cc » ('j') | no next file with comments »