aw: Fix clearView implementation

aw: Fix clearView implementation

The early out was accidentally dropped in a refactor. Add it back here.
And also add unit tests for clear view.

BUG=448488
Committed: https://crrev.com/83cbc841cb270e9ccea5a9912c9d9a6135ecb731
Cr-Commit-Position: refs/heads/master@{#311399}

[boliu, 2015-01-14 01:18:04]

boliu@chromium.org changed reviewers:
+ hush@chromium.org

[boliu, 2015-01-14 01:18:05]

Fix, with tests!!

[hush (inactive), 2015-01-14 02:06:13]

https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
File android_webview/browser/test/fake_window.cc (right):

https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
android_webview/browser/test/fake_window.cc:56: view_->SetViewVisibility(true);
what does it do?

[boliu, 2015-01-14 02:08:20]

https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
File android_webview/browser/test/fake_window.cc (right):

https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
android_webview/browser/test/fake_window.cc:56: view_->SetViewVisibility(true);
On 2015/01/14 02:06:12, hush wrote:
> what does it do?

WindowVisible is used when scheduling fallback ticks. View visibility isn't used
for anything, and just kept here for consistency.

Conceptually these are states in FakeWindow that can be toggled. Nothing needs
them to be true yet though.

[hush (inactive), 2015-01-14 02:19:19]

On 2015/01/14 02:08:20, boliu wrote:
>
https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
> File android_webview/browser/test/fake_window.cc (right):
> 
>
https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
> android_webview/browser/test/fake_window.cc:56:
view_->SetViewVisibility(true);
> On 2015/01/14 02:06:12, hush wrote:
> > what does it do?
> 
> WindowVisible is used when scheduling fallback ticks. View visibility isn't
used
> for anything, and just kept here for consistency.
> 
> Conceptually these are states in FakeWindow that can be toggled. Nothing needs
> them to be true yet though.

Okay. These are not really required for this new test.

lgtm

[boliu, 2015-01-14 02:23:14]

On 2015/01/14 02:19:19, hush wrote:
> On 2015/01/14 02:08:20, boliu wrote:
> >
>
https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
> > File android_webview/browser/test/fake_window.cc (right):
> > 
> >
>
https://codereview.chromium.org/846323002/diff/1/android_webview/browser/test...
> > android_webview/browser/test/fake_window.cc:56:
> view_->SetViewVisibility(true);
> > On 2015/01/14 02:06:12, hush wrote:
> > > what does it do?
> > 
> > WindowVisible is used when scheduling fallback ticks. View visibility isn't
> used
> > for anything, and just kept here for consistency.
> > 
> > Conceptually these are states in FakeWindow that can be toggled. Nothing
needs
> > them to be true yet though.
> 
> Okay. These are not really required for this new test.

The fallback tick thing is required. The new test requires fallback ticks to be
scheduled and fired (because clearView swallows the onDraw). And it required
window to be visible to fire.

> 
> lgtm

[boliu, 2015-01-14 02:24:09]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-01-14 02:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846323002/1

[commit-bot: I haz the power, 2015-01-14 03:17:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-14 03:18:22]

Patchset 1 (id:??) landed as
https://crrev.com/83cbc841cb270e9ccea5a9912c9d9a6135ecb731
Cr-Commit-Position: refs/heads/master@{#311399}