Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 846323002: aw: Fix clearView implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/browser_view_renderer.h" 5 #include "android_webview/browser/browser_view_renderer.h"
6 #include "android_webview/browser/test/rendering_test.h" 6 #include "android_webview/browser/test/rendering_test.h"
7 7
8 namespace android_webview { 8 namespace android_webview {
9 9
10 class SmokeTest : public RenderingTest { 10 class SmokeTest : public RenderingTest {
11 void StartTest() override { 11 void StartTest() override {
12 browser_view_renderer_->SetContinuousInvalidate(true); 12 browser_view_renderer_->SetContinuousInvalidate(true);
13 } 13 }
14 14
15 void WillOnDraw() override { 15 void WillOnDraw() override {
16 browser_view_renderer_->SetContinuousInvalidate(false); 16 browser_view_renderer_->SetContinuousInvalidate(false);
17 } 17 }
18 18
19 void DidDrawOnRT(SharedRendererState* functor) override { 19 void DidDrawOnRT(SharedRendererState* functor) override {
20 EndTest(); 20 EndTest();
21 } 21 }
22 }; 22 };
23 23
24 RENDERING_TEST_F(SmokeTest); 24 RENDERING_TEST_F(SmokeTest);
25 25
26 class ClearViewTest : public RenderingTest {
27 public:
28 ClearViewTest() : on_draw_count_(0u) {}
29
30 void StartTest() override {
31 browser_view_renderer_->SetContinuousInvalidate(true);
32 browser_view_renderer_->ClearView();
33 }
34
35 void WillOnDraw() override {
36 on_draw_count_++;
37 if (on_draw_count_ == 2u) {
38 browser_view_renderer_->SetContinuousInvalidate(false);
39 }
40 }
41
42 void DidOnDraw(bool success) override {
43 if (on_draw_count_ == 1u) {
44 // First OnDraw should be skipped due to ClearView.
45 EXPECT_FALSE(success);
46 browser_view_renderer_->DidUpdateContent(); // Unset ClearView.
47 } else {
48 // Following OnDraws should succeed.
49 EXPECT_TRUE(success);
50 }
51 }
52
53 void DidDrawOnRT(SharedRendererState* functor) override {
54 EndTest();
55 }
56 private:
57 size_t on_draw_count_;
58 };
59
60 RENDERING_TEST_F(ClearViewTest);
61
26 } // namespace android_webview 62 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698