Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 846223002: Avoid MSVC's C6282 warning (assignment of constant in Boolean context). (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid MSVC's C6282 warning (assignment of constant in Boolean context). By courtesy of /analyze... :-} Committed: https://crrev.com/cf09a5a1912e0b1ba3dd92e4e67358618736f6aa Cr-Commit-Position: refs/heads/master@{#26032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ast.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 11 months ago (2015-01-13 08:07:07 UTC) #2
Yang
On 2015/01/13 08:07:07, Sven Panne wrote: lgtm.
5 years, 11 months ago (2015-01-13 08:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846223002/1
5 years, 11 months ago (2015-01-13 08:09:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 08:37:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 08:37:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf09a5a1912e0b1ba3dd92e4e67358618736f6aa
Cr-Commit-Position: refs/heads/master@{#26032}

Powered by Google App Engine
This is Rietveld 408576698