src/ast.h - Issue 846223002: Avoid MSVC's C6282 warning (assignment of constant in Boolean context).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 846223002: Avoid MSVC's C6282 warning (assignment of constant in Boolean context). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index 43bde6ad25cc736bd89aab639ebb7398ccf6a947..a550c6cfd23e1f67ef2423b4901c48367b29868c 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -3157,7 +3157,8 @@ class AstVisitor BASE_EMBEDDED {

if (stack_overflow_) return true; \

StackLimitCheck check(zone_->isolate()); \

if (!check.HasOverflowed()) return false; \

- return (stack_overflow_ = true); \

+ stack_overflow_ = true; \

+ return true; \

} \

private: \

« no previous file with comments | « no previous file | no next file » | no next file with comments »