Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Issue 846073004: Revert of android: Add entry for 'skia_unittests' to UNIT_TESTS list. (Closed)

Created:
5 years, 11 months ago by jbudorick
Modified:
5 years, 11 months ago
Reviewers:
tfarina, jam, luqui
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, cjhopman, danakj, Sami
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of android: Add entry for 'skia_unittests' to UNIT_TESTS list. (patchset #2 id:20001 of https://codereview.chromium.org/792043006/) Reason for revert: These are consistently failing on android_dbg_tests_recipe. Reproduced locally -- they appear to crash immediately when running with --gtest-list-tests, so we don't get past that point. (The test scripts aren't doing a great job of communicating that crash, but they aren't to blame.) Original issue's description: > android: Add entry for 'skia_unittests' to UNIT_TESTS list. > > That way android_dbg_tests_recipe will be able to run skia_unittests > target. > > BUG=444058 > R=luqui@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293602 TBR=luqui@chromium.org,jam@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=444058 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293604

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
jbudorick
Created Revert of android: Add entry for 'skia_unittests' to UNIT_TESTS list.
5 years, 11 months ago (2015-01-13 01:06:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846073004/1
5 years, 11 months ago (2015-01-13 01:07:57 UTC) #2
tfarina
OK. Could you send the url to the failures?
5 years, 11 months ago (2015-01-13 01:09:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293604
5 years, 11 months ago (2015-01-13 01:10:35 UTC) #4
luqui
Failure here: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/25267
5 years, 11 months ago (2015-01-13 01:11:45 UTC) #5
jbudorick
On 2015/01/13 01:09:56, tfarina wrote: > OK. Could you send the url to the failures? ...
5 years, 11 months ago (2015-01-13 01:12:07 UTC) #6
tfarina
On 2015/01/13 01:12:07, jbudorick wrote: > On 2015/01/13 01:09:56, tfarina wrote: > > OK. Could ...
5 years, 11 months ago (2015-01-13 01:17:18 UTC) #7
tfarina
5 years, 11 months ago (2015-01-13 01:21:11 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/849623004

Powered by Google App Engine
This is Rietveld 408576698