Android: Add skia_unittests to the list of stable test suites.

Android: Add skia_unittests to the list of stable test suites.

That way the android trybots and cq will be able to run it.

It should fix the following error:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/44344/steps/skia_unittests/logs/stdio

Traceback (most recent call last):
          File
          "/b/build/slave/android/build/src/build/android/test_runner.py",
          line 990, in <module>
              sys.exit(main())
            File
          "/b/build/slave/android/build/src/build/android/test_runner.py",
          line 986, in main
              return RunTestsCommand(args, parser)
            File
          "/b/build/slave/android/build/src/build/android/test_runner.py",
          line 880, in RunTestsCommand
              return _RunGTests(args, devices)
            File
          "/b/build/slave/android/build/src/build/android/test_runner.py",
          line 617, in _RunGTests
              runner_factory, tests = gtest_setup.Setup(gtest_options,
                              devices)
            File
          "/b/build/slave/android/build/src/build/android/pylib/gtest/setup.py",
          line 218, in Setup
              tests = _GetTests(test_options, test_package, devices)
            File
          "/b/build/slave/android/build/src/build/android/pylib/gtest/setup.py",
          line 128, in _GetTests
              tests.extend(r.test_list)
          AttributeError: 'BaseTestResult' object has no attribute
                           'test_list

BUG=444058
R=jbudorick@chromium.org

Committed: https://crrev.com/5cf0383101d535fff67108fee295a1325f04b729
Cr-Commit-Position: refs/heads/master@{#311197}

[tfarina, 2015-01-13 01:21:30]

Is this correct?

[jbudorick, 2015-01-13 01:35:24]

On 2015/01/13 01:21:30, tfarina wrote:
> Is this correct?

No, STABLE_TEST_SUITES is only used on bots that are still on annotated buildbot
scripts. This won't have an effect on that crash.

On reproducing locally, I get this in the logcat:

--------- beginning of crash
E/AndroidRuntime( 4427): FATAL EXCEPTION: main
E/AndroidRuntime( 4427): Process: org.chromium.native_test, PID: 4427
E/AndroidRuntime( 4427): java.lang.UnsatisfiedLinkError: No implementation found
for void
org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(java.lang.String,
java.lang.String, java.lang.String, android.content.Context) (tried
Java_org_chromium_native_1test_ChromeNativeTestActivity_nativeRunTests and
Java_org_chromium_native_1test_ChromeNativeTestActivity_nativeRunTests__Ljava_lang_String_2Ljava_lang_String_2Ljava_lang_String_2Landroid_content_Context_2)
E/AndroidRuntime( 4427):  at
org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(Native Method)
E/AndroidRuntime( 4427):  at
org.chromium.native_test.ChromeNativeTestActivity.runTests(ChromeNativeTestActivity.java:81)
E/AndroidRuntime( 4427):  at
org.chromium.native_test.ChromeNativeTestActivity.access$000(ChromeNativeTestActivity.java:24)
E/AndroidRuntime( 4427):  at
org.chromium.native_test.ChromeNativeTestActivity$2.run(ChromeNativeTestActivity.java:67)
E/AndroidRuntime( 4427):  at android.os.Handler.handleCallback(Handler.java:739)
E/AndroidRuntime( 4427):  at android.os.Handler.dispatchMessage(Handler.java:95)
E/AndroidRuntime( 4427):  at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime( 4427):  at
android.app.ActivityThread.main(ActivityThread.java:5221)
E/AndroidRuntime( 4427):  at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime( 4427):  at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime( 4427):  at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
E/AndroidRuntime( 4427):  at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
W/ActivityManager(  775):   Force finishing activity
org.chromium.native_test/.ChromeNativeTestActivity

which may mean that we're not building the skia_unittests_apk target correctly.

[tfarina, 2015-01-13 01:39:12]

On Mon, Jan 12, 2015 at 11:35 PM, <jbudorick@chromium.org> wrote:

> On 2015/01/13 01:21:30, tfarina wrote:
>
>> Is this correct?
>>
>
> No, STABLE_TEST_SUITES is only used on bots that are still on annotated
> buildbot
> scripts. This won't have an effect on that crash.
>
> On reproducing locally, I get this in the logcat:
>
> --------- beginning of crash
> E/AndroidRuntime( 4427): FATAL EXCEPTION: main
> E/AndroidRuntime( 4427): Process: org.chromium.native_test, PID: 4427
> E/AndroidRuntime( 4427): java.lang.UnsatisfiedLinkError: No
> implementation found
> for void
> org.chromium.native_test.ChromeNativeTestActivity.
> nativeRunTests(java.lang.String,
> java.lang.String, java.lang.String, android.content.Context) (tried
> Java_org_chromium_native_1test_ChromeNativeTestActivity_nativeRunTests and
> Java_org_chromium_native_1test_ChromeNativeTestActivity_
> nativeRunTests__Ljava_lang_String_2Ljava_lang_String_
> 2Ljava_lang_String_2Landroid_content_Context_2)
> E/AndroidRuntime( 4427):  at
> org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(Native
> Method)
> E/AndroidRuntime( 4427):  at
> org.chromium.native_test.ChromeNativeTestActivity.runTests(
> ChromeNativeTestActivity.java:81)
> E/AndroidRuntime( 4427):  at
> org.chromium.native_test.ChromeNativeTestActivity.access$000(
> ChromeNativeTestActivity.java:24)
> E/AndroidRuntime( 4427):  at
> org.chromium.native_test.ChromeNativeTestActivity$2.
> run(ChromeNativeTestActivity.java:67)
> E/AndroidRuntime( 4427):  at android.os.Handler.
> handleCallback(Handler.java:739)
> E/AndroidRuntime( 4427):  at android.os.Handler.
> dispatchMessage(Handler.java:95)
> E/AndroidRuntime( 4427):  at android.os.Looper.loop(Looper.java:135)
> E/AndroidRuntime( 4427):  at
> android.app.ActivityThread.main(ActivityThread.java:5221)
> E/AndroidRuntime( 4427):  at java.lang.reflect.Method.invoke(Native
> Method)
> E/AndroidRuntime( 4427):  at java.lang.reflect.Method.
> invoke(Method.java:372)
> E/AndroidRuntime( 4427):  at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(
> ZygoteInit.java:899)
> E/AndroidRuntime( 4427):  at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
> W/ActivityManager(  775):   Force finishing activity
> org.chromium.native_test/.ChromeNativeTestActivity
>
> which may mean that we're not building the skia_unittests_apk target
> correctly.
>
building or running? I'm confused now.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbudorick, 2015-01-13 01:43:40]

On 2015/01/13 01:39:12, tfarina wrote:
> On Mon, Jan 12, 2015 at 11:35 PM, <mailto:jbudorick@chromium.org> wrote:
> 
> > On 2015/01/13 01:21:30, tfarina wrote:
> >
> >> Is this correct?
> >>
> >
> > No, STABLE_TEST_SUITES is only used on bots that are still on annotated
> > buildbot
> > scripts. This won't have an effect on that crash.
> >
> > On reproducing locally, I get this in the logcat:
> >
> > --------- beginning of crash
> > E/AndroidRuntime( 4427): FATAL EXCEPTION: main
> > E/AndroidRuntime( 4427): Process: org.chromium.native_test, PID: 4427
> > E/AndroidRuntime( 4427): java.lang.UnsatisfiedLinkError: No
> > implementation found
> > for void
> > org.chromium.native_test.ChromeNativeTestActivity.
> > nativeRunTests(java.lang.String,
> > java.lang.String, java.lang.String, android.content.Context) (tried
> > Java_org_chromium_native_1test_ChromeNativeTestActivity_nativeRunTests and
> > Java_org_chromium_native_1test_ChromeNativeTestActivity_
> > nativeRunTests__Ljava_lang_String_2Ljava_lang_String_
> > 2Ljava_lang_String_2Landroid_content_Context_2)
> > E/AndroidRuntime( 4427):  at
> > org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(Native
> > Method)
> > E/AndroidRuntime( 4427):  at
> > org.chromium.native_test.ChromeNativeTestActivity.runTests(
> > ChromeNativeTestActivity.java:81)
> > E/AndroidRuntime( 4427):  at
> > org.chromium.native_test.ChromeNativeTestActivity.access$000(
> > ChromeNativeTestActivity.java:24)
> > E/AndroidRuntime( 4427):  at
> > org.chromium.native_test.ChromeNativeTestActivity$2.
> > run(ChromeNativeTestActivity.java:67)
> > E/AndroidRuntime( 4427):  at android.os.Handler.
> > handleCallback(Handler.java:739)
> > E/AndroidRuntime( 4427):  at android.os.Handler.
> > dispatchMessage(Handler.java:95)
> > E/AndroidRuntime( 4427):  at android.os.Looper.loop(Looper.java:135)
> > E/AndroidRuntime( 4427):  at
> > android.app.ActivityThread.main(ActivityThread.java:5221)
> > E/AndroidRuntime( 4427):  at java.lang.reflect.Method.invoke(Native
> > Method)
> > E/AndroidRuntime( 4427):  at java.lang.reflect.Method.
> > invoke(Method.java:372)
> > E/AndroidRuntime( 4427):  at
> > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(
> > ZygoteInit.java:899)
> > E/AndroidRuntime( 4427):  at
> > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
> > W/ActivityManager(  775):   Force finishing activity
> > org.chromium.native_test/.ChromeNativeTestActivity
> >
> > which may mean that we're not building the skia_unittests_apk target
> > correctly.
> >
> building or running? I'm confused now.
> 
> -- 
> Thiago Farina
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I suspect (though haven't yet confirmed) that there's something wrong with how
we're building that target that comes up at runtime. The important part is this:

"No implementation found for void
org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests"

Still investigating.

[jbudorick, 2015-01-13 01:55:52]

On 2015/01/13 01:43:40, jbudorick wrote:
> On 2015/01/13 01:39:12, tfarina wrote:
> > On Mon, Jan 12, 2015 at 11:35 PM, <mailto:jbudorick@chromium.org> wrote:
> > 
> > > On 2015/01/13 01:21:30, tfarina wrote:
> > >
> > >> Is this correct?
> > >>
> > >
> > > No, STABLE_TEST_SUITES is only used on bots that are still on annotated
> > > buildbot
> > > scripts. This won't have an effect on that crash.
> > >
> > > On reproducing locally, I get this in the logcat:
> > >
> > > --------- beginning of crash
> > > E/AndroidRuntime( 4427): FATAL EXCEPTION: main
> > > E/AndroidRuntime( 4427): Process: org.chromium.native_test, PID: 4427
> > > E/AndroidRuntime( 4427): java.lang.UnsatisfiedLinkError: No
> > > implementation found
> > > for void
> > > org.chromium.native_test.ChromeNativeTestActivity.
> > > nativeRunTests(java.lang.String,
> > > java.lang.String, java.lang.String, android.content.Context) (tried
> > > Java_org_chromium_native_1test_ChromeNativeTestActivity_nativeRunTests and
> > > Java_org_chromium_native_1test_ChromeNativeTestActivity_
> > > nativeRunTests__Ljava_lang_String_2Ljava_lang_String_
> > > 2Ljava_lang_String_2Landroid_content_Context_2)
> > > E/AndroidRuntime( 4427):  at
> > > org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(Native
> > > Method)
> > > E/AndroidRuntime( 4427):  at
> > > org.chromium.native_test.ChromeNativeTestActivity.runTests(
> > > ChromeNativeTestActivity.java:81)
> > > E/AndroidRuntime( 4427):  at
> > > org.chromium.native_test.ChromeNativeTestActivity.access$000(
> > > ChromeNativeTestActivity.java:24)
> > > E/AndroidRuntime( 4427):  at
> > > org.chromium.native_test.ChromeNativeTestActivity$2.
> > > run(ChromeNativeTestActivity.java:67)
> > > E/AndroidRuntime( 4427):  at android.os.Handler.
> > > handleCallback(Handler.java:739)
> > > E/AndroidRuntime( 4427):  at android.os.Handler.
> > > dispatchMessage(Handler.java:95)
> > > E/AndroidRuntime( 4427):  at android.os.Looper.loop(Looper.java:135)
> > > E/AndroidRuntime( 4427):  at
> > > android.app.ActivityThread.main(ActivityThread.java:5221)
> > > E/AndroidRuntime( 4427):  at java.lang.reflect.Method.invoke(Native
> > > Method)
> > > E/AndroidRuntime( 4427):  at java.lang.reflect.Method.
> > > invoke(Method.java:372)
> > > E/AndroidRuntime( 4427):  at
> > > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(
> > > ZygoteInit.java:899)
> > > E/AndroidRuntime( 4427):  at
> > > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
> > > W/ActivityManager(  775):   Force finishing activity
> > > org.chromium.native_test/.ChromeNativeTestActivity
> > >
> > > which may mean that we're not building the skia_unittests_apk target
> > > correctly.
> > >
> > building or running? I'm confused now.
> > 
> > -- 
> > Thiago Farina
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> I suspect (though haven't yet confirmed) that there's something wrong with how
> we're building that target that comes up at runtime. The important part is
this:
> 
> "No implementation found for void
> org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests"
> 
> Still investigating.

We need to add this:

        ['OS == "android"', {
          'dependencies': [
            '../testing/android/native_test.gyp:native_test_native_code',
          ],
        }],

to the skia_unittests target in skia_tests.gyp.

(it's ok to leave skia_unittests in STABLE_TEST_SUITES, though)

[tfarina, 2015-01-13 02:06:31]

Thanks for the investigation! Done.

Please, could you take another look?

[jbudorick, 2015-01-13 02:13:05]

lgtm

[tfarina, 2015-01-13 02:24:41]

tfarina@chromium.org changed reviewers:
+ thakis@chromium.org

[tfarina, 2015-01-13 02:24:59]

On 2015/01/13 02:13:05, jbudorick wrote:
> lgtm

+Nico, for gyp change!

[Nico, 2015-01-13 03:00:39]

rs-lgtm

[tfarina, 2015-01-13 03:05:05]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-01-13 03:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/849623004/20001

[commit-bot: I haz the power, 2015-01-13 03:33:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-13 03:35:28]

Patchset 2 (id:??) landed as
https://crrev.com/5cf0383101d535fff67108fee295a1325f04b729
Cr-Commit-Position: refs/heads/master@{#311197}