compositor: Fix texture flipping for SW mirroring with surfaceless

content/browser/compositor/reflector_impl.h

Index: content/browser/compositor/reflector_impl.h
diff --git a/content/browser/compositor/reflector_impl.h b/content/browser/compositor/reflector_impl.h
index 4d0da018ded46f53fc425457986b943de4db0669..638ee4410c203911617020282fe01908d76dfd39 100644
--- a/content/browser/compositor/reflector_impl.h
+++ b/content/browser/compositor/reflector_impl.h
@@ -78,6 +78,8 @@ class ReflectorImpl : public base::SupportsWeakPtr<ReflectorImpl>,
   void DetachFromOutputSurface();
 
  private:
+  friend class ReflectorImplTest;
+
   struct MainThreadData {
     MainThreadData(ui::Compositor* mirrored_compositor,
                    ui::Layer* mirroring_layer);
@@ -110,7 +112,8 @@ class ReflectorImpl : public base::SupportsWeakPtr<ReflectorImpl>,
   // Request full redraw on mirroring compositor.
   void FullRedrawOnMainThread(gfx::Size size);
 
-  void UpdateSubBufferOnMainThread(gfx::Size size, gfx::Rect rect);
+  void UpdateSubBufferOnMainThread(const gfx::Size& size,
+                                   const gfx::Rect& rect);
 
   // Request full redraw on mirrored compositor so that
   // the full content will be copied to mirroring compositor.
@@ -133,6 +136,7 @@ class ReflectorImpl : public base::SupportsWeakPtr<ReflectorImpl>,
   scoped_refptr<base::MessageLoopProxy> impl_message_loop_;
   scoped_refptr<base::MessageLoopProxy> main_message_loop_;
   int surface_id_;
+  bool flip_texture_;

[danakj, 2015/01/22 01:04:20]

Thanks for the test this looks nice except I think this is a data race. This
variable should be a member of ImplThreadData or MainThreadData and used on the
correct thread or posted to the other.

[achaulk, 2015/01/23 16:45:52]

Done.

 };
 
 }  // namespace content