compositor: Fix texture flipping for SW mirroring with surfaceless

content/browser/compositor/reflector_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_COMPOSITOR_REFLECTOR_IMPL_H_
 #define CONTENT_BROWSER_COMPOSITOR_REFLECTOR_IMPL_H_
 
 #include "base/id_map.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 60 matching lines @@
   // impl thread.
   void CreateSharedTextureOnMainThread(gfx::Size size);
 
   // Called when the source surface is bound and available. This must
   // be called on ImplThread.
   void OnSourceSurfaceReady(BrowserCompositorOutputSurface* surface);
 
   void DetachFromOutputSurface();
 
  private:
+  friend class ReflectorImplTest;
+
   struct MainThreadData {
     MainThreadData(ui::Compositor* mirrored_compositor,
                    ui::Layer* mirroring_layer);
     ~MainThreadData();
     scoped_refptr<OwnedMailbox> mailbox;
     bool needs_set_mailbox;
     ui::Compositor* mirrored_compositor;
     ui::Layer* mirroring_layer;
   };
 
@@ skipping 12 matching lines @@
 
   void AttachToOutputSurfaceOnImplThread(
       const gpu::MailboxHolder& mailbox_holder,
       BrowserCompositorOutputSurface* surface);
 
   void UpdateTextureSizeOnMainThread(gfx::Size size);
 
   // Request full redraw on mirroring compositor.
   void FullRedrawOnMainThread(gfx::Size size);
 
-  void UpdateSubBufferOnMainThread(gfx::Size size, gfx::Rect rect);
+  void UpdateSubBufferOnMainThread(const gfx::Size& size,
+                                   const gfx::Rect& rect);
 
   // Request full redraw on mirrored compositor so that
   // the full content will be copied to mirroring compositor.
   void FullRedrawContentOnMainThread();
 
   // This exists just to hold a reference to a ReflectorImpl in a post task,
   // so the ReflectorImpl gets deleted when the function returns.
   static void DeleteOnMainThread(scoped_refptr<ReflectorImpl> reflector) {}
 
   MainThreadData& GetMain();
   ImplThreadData& GetImpl();
 
   // Must be accessed only on ImplThread, through GetImpl().
   ImplThreadData impl_unsafe_;
 
   // Must be accessed only on MainThread, through GetMain().
   MainThreadData main_unsafe_;
 
   // Can be accessed on both.
   scoped_refptr<base::MessageLoopProxy> impl_message_loop_;
   scoped_refptr<base::MessageLoopProxy> main_message_loop_;
   int surface_id_;
+  bool flip_texture_;

[danakj, 2015/01/22 01:04:20]

Thanks for the test this looks nice except I think this is a data race. This
variable should be a member of ImplThreadData or MainThreadData and used on the
correct thread or posted to the other.

[achaulk, 2015/01/23 16:45:52]

Done.

 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_COMPOSITOR_REFLECTOR_IMPL_H_