Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 846053002: Handle accent keys from physical keyboards. (Closed)

Created:
5 years, 11 months ago by bcwhite
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Target Ref:
refs/pending/branch-heads/2214
Project:
chromium
Visibility:
Public.

Description

Handle accent keys from physical keyboards. BUG=230921 Review URL: https://codereview.chromium.org/759033002 Cr-Commit-Position: refs/heads/master@{#307474} (cherry picked from commit 13ff5ad10cb62596ebd35e27ab9dbb002dcada17) Fix problem with accents caused by race condition. The deleting of the temporary accent character will cause the pending accent to be cleared so we have to keep it around for the keypress and separately record what the new pending-accent will be once we're done. BUG=230921 Review URL: https://codereview.chromium.org/834293002 Cr-Commit-Position: refs/heads/master@{#310164} (cherry picked from commit b9ef84152bce335b4814175204744ea2d5b148b4) BUG=230921 TBR=bcwhite Committed: https://chromium.googlesource.com/chromium/src/+/554f71edfbb0c03a80b2e243b5d3aef76f9e6b69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -22 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 9 chunks +83 lines, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 5 chunks +15 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
bcwhite
5 years, 11 months ago (2015-01-12 17:41:29 UTC) #2
bcwhite
5 years, 11 months ago (2015-01-12 18:17:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
554f71edfbb0c03a80b2e243b5d3aef76f9e6b69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698