Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 834293002: Fix problem with accents caused by race condition. (Closed)

Created:
5 years, 11 months ago by bcwhite
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix problem with accents caused by race condition. The deleting of the temporary accent character will cause the pending accent to be cleared so we have to keep it around for the keypress and separately record what the new pending-accent will be once we're done. BUG=230921 Committed: https://crrev.com/b9ef84152bce335b4814175204744ea2d5b148b4 Cr-Commit-Position: refs/heads/master@{#310164}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 4 chunks +15 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 9 (2 generated)
bcwhite
5 years, 11 months ago (2015-01-06 14:56:31 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 11 months ago (2015-01-06 21:10:16 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/834293002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (left): https://chromiumcodereview.appspot.com/834293002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#oldcode633 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:633: assertUpdateStateCall(mConnection, 1000); What is the reason we no longer ...
5 years, 11 months ago (2015-01-06 21:12:39 UTC) #4
bcwhite
https://chromiumcodereview.appspot.com/834293002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (left): https://chromiumcodereview.appspot.com/834293002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#oldcode633 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:633: assertUpdateStateCall(mConnection, 1000); On 2015/01/06 21:12:39, aurimas wrote: > What ...
5 years, 11 months ago (2015-01-06 22:08:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834293002/1
5 years, 11 months ago (2015-01-06 22:09:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 23:03:51 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:04:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ef84152bce335b4814175204744ea2d5b148b4
Cr-Commit-Position: refs/heads/master@{#310164}

Powered by Google App Engine
This is Rietveld 408576698