Issue 845963006: The Sky compositor should recycle textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 845963006: The Sky compositor should recycle textures (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

The Sky compositor should recycle textures Previously, we were creating a new texture for every frame. Using tracing on a Nexus 5, that appears to cost about 6ms per frame on the GPU thread. After this CL, we keep a cache of recently used textures and only allocate a new one when either (1) we don't have one free or (2) our size requirements have changed. If our size requirements change, we dump the whole texture cache. In the future, we'll probably need something fancier if we ever need more than one size texture per frame. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a229acb4197a27e6be312ab7171488da9c50632e

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -1 line)			Patch
M	mojo/converters/geometry/geometry_type_converters.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sky/compositor/resource_manager.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	sky/compositor/resource_manager.cc	View	2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/845963006/diff/1/sky/compositor/resource_manager.cc File sky/compositor/resource_manager.cc (right): https://codereview.chromium.org/845963006/diff/1/sky/compositor/resource_manager.cc#newcode95 sky/compositor/resource_manager.cc:95: // TODO(abarth): Consider recycling the texture. this can ...

5 years, 11 months ago (2015-01-15 18:51:51 UTC) #2

abarth-chromium

5 years, 11 months ago (2015-01-15 19:10:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a229acb4197a27e6be312ab7171488da9c50632e (presubmit successful).

Expand Messages | Collapse Messages