Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 845843002: Clean up QUIC field trial parsing code. (Closed)

Created:
5 years, 11 months ago by Ryan Hamilton
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up QUIC field trial parsing code. Committed: https://crrev.com/e9efff4491d5d132829e0684b5f5e396fadd4129 Cr-Commit-Position: refs/heads/master@{#311064}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : re-remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -40 lines) Patch
M chrome/browser/io_thread.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 4 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 2 12 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Ryan Hamilton
5 years, 11 months ago (2015-01-09 23:24:29 UTC) #2
ramant (doing other things)
lgtm
5 years, 11 months ago (2015-01-09 23:26:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845843002/1
5 years, 11 months ago (2015-01-09 23:29:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/108820) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/47531) android_arm64_dbg_recipe ...
5 years, 11 months ago (2015-01-09 23:34:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845843002/20001
5 years, 11 months ago (2015-01-10 00:30:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/43935)
5 years, 11 months ago (2015-01-10 01:21:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845843002/40001
5 years, 11 months ago (2015-01-12 17:01:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-12 17:58:46 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 18:02:14 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9efff4491d5d132829e0684b5f5e396fadd4129
Cr-Commit-Position: refs/heads/master@{#311064}

Powered by Google App Engine
This is Rietveld 408576698