Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3488)

Unified Diff: chrome/browser/io_thread.cc

Issue 845843002: Clean up QUIC field trial parsing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-remove test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index cf1e647b31a3e82ee47c1ccad51eb4ce01ed1ddf..48654c9957976dbc6a749cdb66d7b38e46e99bf4 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -1243,14 +1243,12 @@ void IOThread::ConfigureQuicGlobals(
ShouldEnableQuicPortSelection(command_line));
globals->quic_connection_options =
GetQuicConnectionOptions(command_line, quic_trial_params);
- if (ShouldEnableQuicPacing(command_line, quic_trial_group,
- quic_trial_params)) {
+ if (ShouldEnableQuicPacing(command_line, quic_trial_params)) {
globals->quic_connection_options.push_back(net::kPACE);
}
}
size_t max_packet_length = GetQuicMaxPacketLength(command_line,
- quic_trial_group,
quic_trial_params);
if (max_packet_length != 0) {
globals->quic_max_packet_length.set(max_packet_length);
@@ -1314,7 +1312,6 @@ bool IOThread::ShouldEnableQuicPortSelection(
bool IOThread::ShouldEnableQuicPacing(
const base::CommandLine& command_line,
- base::StringPiece quic_trial_group,
const VariationParameters& quic_trial_params) {
if (command_line.HasSwitch(switches::kEnableQuicPacing))
return true;
@@ -1338,10 +1335,7 @@ net::QuicTagVector IOThread::GetQuicConnectionOptions(
VariationParameters::const_iterator it =
quic_trial_params.find("connection_options");
if (it == quic_trial_params.end()) {
- // TODO(rch): remove support for deprecated congestion_options.
- it = quic_trial_params.find("congestion_options");
- if (it == quic_trial_params.end())
- return net::QuicTagVector();
+ return net::QuicTagVector();
}
return net::QuicUtils::ParseQuicConnectionOptions(it->second);
@@ -1434,7 +1428,6 @@ bool IOThread::ShouldQuicEnableTruncatedConnectionIds(
// static
size_t IOThread::GetQuicMaxPacketLength(
const base::CommandLine& command_line,
- base::StringPiece quic_trial_group,
const VariationParameters& quic_trial_params) {
if (command_line.HasSwitch(switches::kQuicMaxPacketLength)) {
unsigned value;
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698