|
|
Chromium Code Reviews
DescriptionAdd new labels to net bug triage docs.
BUG=none
NOTRY=true
Committed: https://crrev.com/4a43a9c3dc7094e2673f6c5e9ed2c200db53543e
Cr-Commit-Position: refs/heads/master@{#310811}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rework filter error description #
Total comments: 4
Patch Set 3 : Update connectivity description #Messages
Total messages: 17 (2 generated)
mmenke@chromium.org changed reviewers: + pauljensen@chromium.org, rdsmith@chromium.org
Had two new labels added to the bug tracker, so people can use a label instead of CCing you on issues in your domains. How's this text look? Also, you should be sure to subscribe to the new label on the bug tracker, so it doesn't become a black hole.
Remind me how to subscribe to bug tracker labels? https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.txt File net/docs/bug-triage-labels.txt (right): https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.t... net/docs/bug-triage-labels.txt:33: ERR_CONTENT_DECODING_FAILED. I'd like to have some verbiage in here about failures that lead into filter.cc as well. There was a filter issue that lead to pure corruption, not just decoding failed. Does that make sense to you?
On 2015/01/08 22:46:38, rdsmith wrote: > Remind me how to subscribe to bug tracker labels? > > https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.txt > File net/docs/bug-triage-labels.txt (right): > > https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.t... > net/docs/bug-triage-labels.txt:33: ERR_CONTENT_DECODING_FAILED. > I'd like to have some verbiage in here about failures that lead into filter.cc > as well. There was a filter issue that lead to pure corruption, not just > decoding failed. Does that make sense to you? https://code.google.com/p/chromium/issues/list -> subscriptions -> just paste in a list of labels you want to subscribe to (It says "space separated", so I've been too paranoid to see if they can be on different lines or not, which makes for an ugly list). I'll respond to your comment tomorrow.
On 2015/01/08 22:48:38, mmenke wrote: > On 2015/01/08 22:46:38, rdsmith wrote: > > Remind me how to subscribe to bug tracker labels? > > > > > https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.txt > > File net/docs/bug-triage-labels.txt (right): > > > > > https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.t... > > net/docs/bug-triage-labels.txt:33: ERR_CONTENT_DECODING_FAILED. > > I'd like to have some verbiage in here about failures that lead into filter.cc > > as well. There was a filter issue that lead to pure corruption, not just > > decoding failed. Does that make sense to you? > > https://code.google.com/p/chromium/issues/list -> subscriptions -> just paste in > a list of labels you want to subscribe to (It says "space separated", so I've > been too paranoid to see if they can be on different lines or not, which makes > for an ugly list). > > I'll respond to your comment tomorrow. Subscribed; thank you.
https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.txt File net/docs/bug-triage-labels.txt (right): https://codereview.chromium.org/845613002/diff/1/net/docs/bug-triage-labels.t... net/docs/bug-triage-labels.txt:33: ERR_CONTENT_DECODING_FAILED. On 2015/01/08 22:46:38, rdsmith wrote: > I'd like to have some verbiage in here about failures that lead into filter.cc > as well. There was a filter issue that lead to pure corruption, not just > decoding failed. Does that make sense to you? I don't want to make it sound like the definitive cause of all corruption issues. That having been said, I've add a mention of corruption. WDYT?
LGTM. I'm still not completely happy, as there was at least one bug that wasn't in SDCH or GZIP but in the framework, but that's probably "implementation details" (i.e. label owner can triage).
On 2015/01/09 18:28:19, rdsmith wrote: > LGTM. I'm still not completely happy, as there was at least one bug that wasn't > in SDCH or GZIP but in the framework, but that's probably "implementation > details" (i.e. label owner can triage). This isn't meant to be a complete list, just hints that will hopefully help in most cases. That having been said, once this has been landed, I'm happy to sign off on updates to the descriptions.
https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... File net/docs/bug-triage-labels.txt (left): https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... net/docs/bug-triage-labels.txt:29: * Connectivity issues (ERR_NETWORK_CHANGED, system always thinking it's offline) Could you add back the bit about Chrome thinking it's offline when it's not? Perhaps "navigator.onLine inaccuracies". https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... File net/docs/bug-triage-labels.txt (right): https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... net/docs/bug-triage-labels.txt:30: networks issues, ERR_NETWORK_CHANGED when there's no actual network Issues is repeated.
https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... File net/docs/bug-triage-labels.txt (left): https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... net/docs/bug-triage-labels.txt:29: * Connectivity issues (ERR_NETWORK_CHANGED, system always thinking it's offline) On 2015/01/09 18:38:52, pauljensen wrote: > Could you add back the bit about Chrome thinking it's offline when it's not? > Perhaps "navigator.onLine inaccuracies". Added both. https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... File net/docs/bug-triage-labels.txt (right): https://codereview.chromium.org/845613002/diff/20001/net/docs/bug-triage-labe... net/docs/bug-triage-labels.txt:30: networks issues, ERR_NETWORK_CHANGED when there's no actual network On 2015/01/09 18:38:52, pauljensen wrote: > Issues is repeated. Done.
Lgtm. Do we need to add these labels in crbug.com somewhere? Will these new labels cause the bugs to be automatically assigned to Randy and I?
On 2015/01/09 18:52:21, pauljensen wrote: > Lgtm. Do we need to add these labels in http://crbug.com somewhere? Will these new > labels cause the bugs to be automatically assigned to Randy and I? The labels have already been added. You'll need to subscribe to the new label yourself (And it won't assign issues, just send comments to them to you via email, like if you're on the CC list, or have the issue starred). To subscribe: https://code.google.com/p/chromium/issues/list -> subscriptions -> just paste in a list of labels you want to subscribe to (It says "space separated", so I've been too paranoid to see if they can be on different lines or not, which makes for a fairly ugly list).
On 2015/01/09 18:57:37, mmenke wrote: > On 2015/01/09 18:52:21, pauljensen wrote: > > Lgtm. Do we need to add these labels in http://crbug.com somewhere? Will > these new > > labels cause the bugs to be automatically assigned to Randy and I? > > The labels have already been added. You'll need to subscribe to the new label > yourself (And it won't assign issues, just send comments to them to you via > email, like if you're on the CC list, or have the issue starred). > > To subscribe: https://code.google.com/p/chromium/issues/list -> subscriptions > -> just paste in a list of labels you want to subscribe to (It says "space > separated", so I've been too paranoid to see if they can be on different lines > or not, which makes for a fairly ugly list). Oh, and to request new labels, just for future reference, laforge is the one to contact.
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845613002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4a43a9c3dc7094e2673f6c5e9ed2c200db53543e Cr-Commit-Position: refs/heads/master@{#310811} |
