Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: net/docs/bug-triage-labels.txt

Issue 845613002: Add new labels to net bug triage docs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update connectivity description Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Some network label caveats 1 Some network label caveats
2 * Cr-UI-Browser-Downloads: Despite the name, this covers all issues related to 2 * Cr-UI-Browser-Downloads: Despite the name, this covers all issues related to
3 downloading a file except saving entire pages (Which is Cr-Blink-SavePage), 3 downloading a file except saving entire pages (Which is Cr-Blink-SavePage),
4 not just UI issues. Most downloads bugs will have the word "download" or 4 not just UI issues. Most downloads bugs will have the word "download" or
5 "save as" in the description. Issues with the HTTP server for the Chrome 5 "save as" in the description. Issues with the HTTP server for the Chrome
6 binaries are not downloads bugs. 6 binaries are not downloads bugs.
7 * Cr-UI-Browser-SafeBrowsing: Bugs that have to do with the process by which a 7 * Cr-UI-Browser-SafeBrowsing: Bugs that have to do with the process by which a
8 URL or file is determined to be dangerous based on our databases, or the 8 URL or file is determined to be dangerous based on our databases, or the
9 resulting interstitials. Determination of danger based purely on 9 resulting interstitials. Determination of danger based purely on
10 content-type or file extension belongs in Cr-UI-Browser-Downloads, not 10 content-type or file extension belongs in Cr-UI-Browser-Downloads, not
11 SafeBrowsing. 11 SafeBrowsing.
12 * Cr-Internals-Network-SSL: This includes issues that should be also tagged as 12 * Cr-Internals-Network-SSL: This includes issues that should be also tagged as
13 Cr-Security-UX (certificate error pages or other security interstitials, 13 Cr-Security-UX (certificate error pages or other security interstitials,
14 omnibox indicators that a page is secure), and more general SSL issues. If 14 omnibox indicators that a page is secure), and more general SSL issues. If
15 you see requests that die in the SSL negotiation phase, in particular, this 15 you see requests that die in the SSL negotiation phase, in particular, this
16 is often the correct label. 16 is often the correct label.
17 * Cr-Internals-Network-DataProxy: Flywheel / the Data Reduction Proxy. Issues 17 * Cr-Internals-Network-DataProxy: Flywheel / the Data Reduction Proxy. Issues
18 require “Reduce Data Usage” be turned on. Proxy url is 18 require "Reduce Data Usage" be turned on. Proxy url is
19 https://proxy.googlezip.net:443, with compress.googlezip.net:80 as a 19 https://proxy.googlezip.net:443, with compress.googlezip.net:80 as a
20 fallback. Currently Android and iOS only. 20 fallback. Currently Android and iOS only.
21 * Cr-Internals-Network-Cache: The cache is the layer that handles most range 21 * Cr-Internals-Network-Cache: The cache is the layer that handles most range
22 request logic (Though range requests may also be issued by the PDF plugin, 22 request logic (Though range requests may also be issued by the PDF plugin,
23 XHRs, or other components). 23 XHRs, or other components).
24 * Cr-Internals-Network-SPDY: Covers HTTP2 as well. 24 * Cr-Internals-Network-SPDY: Covers HTTP2 as well.
25 * Cr-Internals-Network-HTTP: Typically not used. Unclear what it covers, and 25 * Cr-Internals-Network-HTTP: Typically not used. Unclear what it covers, and
26 there's no specific HTTP owner. 26 there's no specific HTTP owner.
27 * Cr-Internals-Network-Logging: Covers about:net-internals, about:net-export as 27 * Cr-Internals-Network-Logging: Covers about:net-internals, about:net-export as
28 well as the what's sent to the NetLog. 28 well as the what's sent to the NetLog.
29 * Connectivity issues (ERR_NETWORK_CHANGED, system always thinking it's offline) 29 * Cr-Internals-Network-Connectivity: Issues related to switching between
30 don't have a label. There should be assigned to pauljensen@chromium.org. 30 networks, ERR_NETWORK_CHANGED, Chrome thinking it's online when it's not /
31 TODO(mmenke): Should we add a label? 31 navigator.onLine inaccuracies, etc.
32 * SDCH issues should go to rdsmith@chromium.org. 32 * Cr-Internals-Network-Filters: Covers SDCH and gzip issues.
33 TODO(mmenke): Should we add a label? 33 ERR_CONTENT_DECODING_FAILED indicates a problem at this layer, and bugs here
34 can also cause response body corruption.
34 35
35 36
36 Common non-network label reference. Bugs in these areas often receive the 37 Common non-network label reference. Bugs in these areas often receive the
37 Cr-Internals-Network label, though they fall largely outside the purview of the 38 Cr-Internals-Network label, though they fall largely outside the purview of the
38 network stack team: 39 network stack team:
39 * Cr-Blink-Forms: Issues submitting forms, forms having weird data, forms 40 * Cr-Blink-Forms: Issues submitting forms, forms having weird data, forms
40 sending the wrong method, etc. 41 sending the wrong method, etc.
41 * Cr-Blink-Loader: Cross origin issues are sometimes loader related. Blink 42 * Cr-Blink-Loader: Cross origin issues are sometimes loader related. Blink
42 also has an in-memory cache, and when it's used, requests don't appear in 43 also has an in-memory cache, and when it's used, requests don't appear in
43 about:net-internals. Requests for the same URL are also often merged there 44 about:net-internals. Requests for the same URL are also often merged there
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 * Cr-Blink-SecurityFeature: CORS / Cross origin issues. Main frame 78 * Cr-Blink-SecurityFeature: CORS / Cross origin issues. Main frame
78 cross-origin navigation issues are often actually Cr-UI-Browser-Navigation 79 cross-origin navigation issues are often actually Cr-UI-Browser-Navigation
79 issues. 80 issues.
80 * Cr-Privacy: Privacy related bug (History, cookies discoverable by an entity 81 * Cr-Privacy: Privacy related bug (History, cookies discoverable by an entity
81 that shouldn't be able to do so, incognito state being saved in memory or on 82 that shouldn't be able to do so, incognito state being saved in memory or on
82 disk beyond the lifetime of incognito tabs, etc). Generally used in 83 disk beyond the lifetime of incognito tabs, etc). Generally used in
83 conjunction with other labels. 84 conjunction with other labels.
84 * Type-Bug-Security: Security related bug (Allows for code execution from 85 * Type-Bug-Security: Security related bug (Allows for code execution from
85 remote site, allows crossing security boundaries, unchecked array bounds, 86 remote site, allows crossing security boundaries, unchecked array bounds,
86 etc). 87 etc).
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698