sky/engine/v8_inspector/inspector_backend_mojo.cc - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/v8_inspector/inspector_backend_mojo.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/v8_inspector/inspector_backend_mojo.cc

diff --git a/sky/engine/v8_inspector/inspector_backend_mojo.cc b/sky/engine/v8_inspector/inspector_backend_mojo.cc

index df8a08833a2ac5648b421ab9fbaf62f7de7be454..c4349efdead1e40e9653a1ad908980b30f903c96 100644

--- a/sky/engine/v8_inspector/inspector_backend_mojo.cc

+++ b/sky/engine/v8_inspector/inspector_backend_mojo.cc

@@ -111,7 +111,7 @@ void InspectorBackendMojoImpl::Connect() {

service_provider_request.Bind(pipe.handle0.Pass());

inspector_service_provider_.BindToHandle(pipe.handle1.Pass());

shell->ConnectToApplication("mojo:sky_inspector_server",

- service_provider_request.Pass());

+ service_provider_request.Pass(), nullptr);

mojo::ConnectToService(&inspector_service_provider_, &frontend_);

// Theoretically we should load our state from the inspector cookie.

« no previous file with comments | « sky/compositor/surface_holder.cc ('k') | sky/viewer/content_handler_impl.cc » ('j') | no next file with comments »