sky/compositor/surface_holder.cc - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/compositor/surface_holder.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/compositor/surface_holder.cc

diff --git a/sky/compositor/surface_holder.cc b/sky/compositor/surface_holder.cc

index f2ad3297a07d8724d3a5e260732cf1e3884db534..e46490226ef21a453ac7cec4986e32c8aed6be4e 100644

--- a/sky/compositor/surface_holder.cc

+++ b/sky/compositor/surface_holder.cc

@@ -20,7 +20,7 @@ SurfaceHolder::SurfaceHolder(Client* client, mojo::Shell* shell)

: client_(client), id_namespace_(0u), local_id_(0u), weak_factory_(this) {

mojo::ServiceProviderPtr service_provider;

shell->ConnectToApplication("mojo:surfaces_service",

- mojo::GetProxy(&service_provider));

+ mojo::GetProxy(&service_provider), nullptr);

mojo::ConnectToService(service_provider.get(), &surface_);

surface_.set_client(this);

}