Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: shell/external_application_listener_unittest.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/context.cc ('k') | sky/compositor/surface_holder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/external_application_listener_unittest.cc
diff --git a/shell/external_application_listener_unittest.cc b/shell/external_application_listener_unittest.cc
index 5a76f607500b835118fd3e0248898998913dbd53..f8e73169db3cf172a95a6ee08de51ec3135c319f 100644
--- a/shell/external_application_listener_unittest.cc
+++ b/shell/external_application_listener_unittest.cc
@@ -74,12 +74,11 @@ namespace {
class StubShellImpl : public InterfaceImpl<Shell> {
private:
- void ConnectToApplication(
- const String& requestor_url,
- InterfaceRequest<ServiceProvider> in_service_provider) override {
- ServiceProviderPtr out_service_provider;
- out_service_provider.Bind(in_service_provider.PassMessagePipe());
- client()->AcceptConnection(requestor_url, out_service_provider.Pass());
+ void ConnectToApplication(const String& requestor_url,
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) override {
+ client()->AcceptConnection(requestor_url, services.Pass(),
+ exposed_services.Pass());
}
};
@@ -125,7 +124,8 @@ class QuitLoopOnConnectApplicationImpl : public InterfaceImpl<Application> {
void Initialize(Array<String> args) override {}
void AcceptConnection(const String& requestor_url,
- ServiceProviderPtr p) override {
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) override {
DVLOG(1) << url_ << " accepting connection from " << requestor_url;
to_quit_->PostTask(FROM_HERE, quit_callback_);
}
@@ -158,7 +158,7 @@ class FakeExternalApplication {
void ConnectToAppByUrl(std::string app_url) {
ServiceProviderPtr sp;
- ptr_->ConnectToApplication(app_url, GetProxy(&sp));
+ ptr_->ConnectToApplication(app_url, GetProxy(&sp), nullptr);
}
const std::string& url() { return url_; }
« no previous file with comments | « shell/context.cc ('k') | sky/compositor/surface_holder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698