Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: mojo/application_manager/shell_impl.h

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application_manager/application_manager.cc ('k') | mojo/application_manager/shell_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/shell_impl.h
diff --git a/mojo/application_manager/shell_impl.h b/mojo/application_manager/shell_impl.h
index ff35548e803e870ef74b9be01719f7103e38680d..58e30666e9eff13e3fcba64f77c28915b6d88b2b 100644
--- a/mojo/application_manager/shell_impl.h
+++ b/mojo/application_manager/shell_impl.h
@@ -29,7 +29,8 @@ class ShellImpl : public Shell, public ErrorHandler {
~ShellImpl() override;
void ConnectToClient(const GURL& requestor_url,
- ServiceProviderPtr service_provider);
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services);
Application* client() { return binding_.client(); }
const GURL& url() const { return url_; }
@@ -41,9 +42,9 @@ class ShellImpl : public Shell, public ErrorHandler {
const GURL& url);
// Shell implementation:
- void ConnectToApplication(
- const String& app_url,
- InterfaceRequest<ServiceProvider> in_service_provider) override;
+ void ConnectToApplication(const String& app_url,
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) override;
// ErrorHandler implementation:
void OnConnectionError() override;
« no previous file with comments | « mojo/application_manager/application_manager.cc ('k') | mojo/application_manager/shell_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698