Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: mojo/application_manager/shell_impl.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application_manager/shell_impl.h ('k') | mojo/gpu/gl_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/shell_impl.cc
diff --git a/mojo/application_manager/shell_impl.cc b/mojo/application_manager/shell_impl.cc
index 52d5380a3b8a90020fe571550a2431e97b96d892..9d391776a2401a19a8e2beb0ac92b3b1b4c028e4 100644
--- a/mojo/application_manager/shell_impl.cc
+++ b/mojo/application_manager/shell_impl.cc
@@ -30,9 +30,10 @@ ShellImpl::~ShellImpl() {
}
void ShellImpl::ConnectToClient(const GURL& requestor_url,
- ServiceProviderPtr service_provider) {
- client()->AcceptConnection(String::From(requestor_url),
- service_provider.Pass());
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) {
+ client()->AcceptConnection(String::From(requestor_url), services.Pass(),
+ exposed_services.Pass());
}
ShellImpl::ShellImpl(ApplicationManager* manager,
@@ -46,17 +47,16 @@ ShellImpl::ShellImpl(ApplicationManager* manager,
}
// Shell implementation:
-void ShellImpl::ConnectToApplication(
- const String& app_url,
- InterfaceRequest<ServiceProvider> in_service_provider) {
- ServiceProviderPtr out_service_provider;
- out_service_provider.Bind(in_service_provider.PassMessagePipe());
+void ShellImpl::ConnectToApplication(const String& app_url,
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) {
GURL app_gurl(app_url);
if (!app_gurl.is_valid()) {
LOG(ERROR) << "Error: invalid URL: " << app_url;
return;
}
- manager_->ConnectToApplication(app_gurl, url_, out_service_provider.Pass());
+ manager_->ConnectToApplication(app_gurl, url_, services.Pass(),
+ exposed_services.Pass());
}
void ShellImpl::OnConnectionError() {
« no previous file with comments | « mojo/application_manager/shell_impl.h ('k') | mojo/gpu/gl_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698