Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: extensions/renderer/resources/guest_view/web_view.js

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/guest_view/surface_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/web_view.js
diff --git a/extensions/renderer/resources/guest_view/web_view.js b/extensions/renderer/resources/guest_view/web_view.js
index 8ba93a7ab46484e612370d1b844a1af41c0552e4..bc31e25ec58ffbcadd014c26a0095a0c84a426f8 100644
--- a/extensions/renderer/resources/guest_view/web_view.js
+++ b/extensions/renderer/resources/guest_view/web_view.js
@@ -74,7 +74,6 @@ WebViewImpl.prototype.onElementDetached = function() {
this.beforeFirstNavigation = true;
this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].validPartitionId =
true;
- this.internalInstanceId = 0;
};
// Sets the <webview>.request property.
@@ -154,17 +153,7 @@ WebViewImpl.prototype.onSizeChanged = function(webViewEvent) {
};
WebViewImpl.prototype.createGuest = function() {
- var params = {
- 'instanceId': this.viewInstanceId,
- 'userAgentOverride': this.userAgentOverride,
- 'width': this.element.offsetWidth,
- 'height': this.element.offsetHeight,
- };
- for (var i in this.attributes) {
- params[i] = this.attributes[i].getValue();
- }
-
- this.guest.create(params, function() {
+ this.guest.create(this.buildParams(), function() {
this.attachWindow();
}.bind(this));
};
@@ -225,7 +214,7 @@ WebViewImpl.prototype.onAttach = function(storagePartitionId) {
storagePartitionId);
};
-WebViewImpl.prototype.buildAttachParams = function() {
+WebViewImpl.prototype.buildContainerParams = function() {
var params = { 'userAgentOverride': this.userAgentOverride };
for (var i in this.attributes) {
params[i] = this.attributes[i].getValue();
« no previous file with comments | « extensions/renderer/resources/guest_view/surface_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698