Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845303005: remove dead code after HQ change (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
humper, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead code after HQ change BUG=skia: Committed: https://skia.googlesource.com/skia/+/94443b8718fa194bb2077324eade66bd68f99b54

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove commented-out code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -395 lines) Patch
M src/core/SkBitmapFilter.cpp View 2 chunks +0 lines, -112 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 5 chunks +0 lines, -23 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 3 chunks +0 lines, -175 lines 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
5 years, 11 months ago (2015-01-20 15:59:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845303005/1
5 years, 11 months ago (2015-01-20 16:00:23 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-20 16:00:24 UTC) #5
robertphillips
lgtm + questions https://codereview.chromium.org/845303005/diff/1/src/core/SkBitmapProcState.h File src/core/SkBitmapProcState.h (right): https://codereview.chromium.org/845303005/diff/1/src/core/SkBitmapProcState.h#newcode105 src/core/SkBitmapProcState.h:105: Can we just delete this? https://codereview.chromium.org/845303005/diff/1/src/core/SkBitmapProcState.h#newcode142 ...
5 years, 11 months ago (2015-01-20 16:34:21 UTC) #7
reed1
https://codereview.chromium.org/845303005/diff/1/src/core/SkBitmapProcState.h File src/core/SkBitmapProcState.h (right): https://codereview.chromium.org/845303005/diff/1/src/core/SkBitmapProcState.h#newcode105 src/core/SkBitmapProcState.h:105: On 2015/01/20 16:34:21, robertphillips wrote: > Can we just ...
5 years, 11 months ago (2015-01-20 16:42:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845303005/20001
5 years, 11 months ago (2015-01-20 16:43:23 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:50:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/94443b8718fa194bb2077324eade66bd68f99b54

Powered by Google App Engine
This is Rietveld 408576698