Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Issue 845293002: skia: blend32_16_row for neon version (Closed)

Created:
5 years, 11 months ago by mlee
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: blend32_16_row for neon version This includes blend32_16_row neon implementation for aarch32 and aarch64. This implementation is moved to proc for code maintenance. BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -6 lines) Patch
M include/core/SkBlitRow.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 7 chunks +24 lines, -6 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +227 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845293002/1
5 years, 11 months ago (2015-01-13 03:23:34 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-13 03:23:34 UTC) #5
commit-bot: I haz the power
Presubmit check for 845293002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 11 months ago (2015-01-13 03:23:39 UTC) #7
mlee
This includes neon implementation for blend32_16_row for aarch32 and aarch64. I am seeing one apk ...
5 years, 11 months ago (2015-01-13 03:30:45 UTC) #9
mlee
Hi, Reviewers, I have one question. Do I need to do anything to see trybot ...
5 years, 11 months ago (2015-01-13 03:32:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845293002/1
5 years, 11 months ago (2015-01-13 03:37:34 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-13 03:37:34 UTC) #13
commit-bot: I haz the power
Presubmit check for 845293002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 11 months ago (2015-01-13 03:37:38 UTC) #15
mlee
Now, I may add reviewers to Reviewers filed correctly...
5 years, 11 months ago (2015-01-13 05:15:59 UTC) #17
mlee
On 2015/01/13 05:15:59, mlee wrote: > Now, I may add reviewers to Reviewers filed correctly... ...
5 years, 11 months ago (2015-01-13 08:19:00 UTC) #18
mtklein
On 2015/01/13 08:19:00, mlee wrote: > On 2015/01/13 05:15:59, mlee wrote: > > Now, I ...
5 years, 11 months ago (2015-01-13 15:16:03 UTC) #19
mlee
5 years, 11 months ago (2015-01-14 10:31:46 UTC) #20
Moving to https://codereview.chromium.org/847363002/ 

I make new one on the top of Reed change.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698