Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/opts/SkBlitRow_opts_arm_neon.cpp

Issue 845293002: skia: blend32_16_row for neon version (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/opts/SkBlitRow_opts_arm_neon.h ('k') | src/opts/SkBlitRow_opts_mips_dsp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/opts/SkBlitRow_opts_arm_neon.cpp
diff --git a/src/opts/SkBlitRow_opts_arm_neon.cpp b/src/opts/SkBlitRow_opts_arm_neon.cpp
index b372d16e2fa030458fb4450db3c0a1f80f83cdd0..a96630a6c8ac5992e7ddff39a277b9a519a114fe 100644
--- a/src/opts/SkBlitRow_opts_arm_neon.cpp
+++ b/src/opts/SkBlitRow_opts_arm_neon.cpp
@@ -465,6 +465,233 @@ void S32A_D565_Opaque_neon(uint16_t* SK_RESTRICT dst,
}
#endif // #ifdef SK_CPU_ARM32
+static uint32_t pmcolor_to_expand16(SkPMColor c) {
+ unsigned r = SkGetPackedR32(c);
+ unsigned g = SkGetPackedG32(c);
+ unsigned b = SkGetPackedB32(c);
+ return (g << 24) | (r << 13) | (b << 2);
+}
+
+void blend32_16_row_neon(const SkPMColor* SK_RESTRICT src,
+ uint16_t dst[], int count) {
+ uint32_t src_expand;
+ unsigned scale;
+
+ if (count <= 0) return;
+ SkASSERT(((size_t)dst & 0x01) == 0);
+
+ /*
+ * This preamble code is in order to make dst aligned to 8 bytes
+ * in the next mutiple bytes read & write access.
+ */
+ src_expand = pmcolor_to_expand16(*src);
+ scale = SkAlpha255To256(0xFF - SkGetPackedA32(*src)) >> 3;
+
+#define DST_ALIGN 8
+
+ /*
+ * preamble_size is in byte, meantime, this blend32_16_row_neon updates 2 bytes at a time.
+ */
+ int preamble_size = (DST_ALIGN - (size_t)dst) & (DST_ALIGN - 1);
+
+ for (int i = 0; i < preamble_size; i+=2, dst++) {
+ uint32_t dst_expand = SkExpand_rgb_16(*dst) * scale;
+ *dst = SkCompact_rgb_16((src_expand + dst_expand) >> 5);
+ if (--count == 0)
+ break;
+ }
+#ifdef SK_CPU_ARM64
+ asm (
+ "lsr x2, %[count], #4 \n\t"
+ "mov x1, x2 \n\t" // calc. count>>4
+ "cbz x1, back \n\t" // if (count>>4) == 0, exit
+ "ld4 {v24.8b, v25.8b, v26.8b, v27.8b}, [%[src]] \n\t" // load eight src ABGR32 pixels
+
+ "uxtl v4.8h, v24.8b \n\t" // widen red to 16 bits
+ "uxtl v5.8h, v25.8b \n\t" // widen green to 16 bits
+ "uxtl v6.8h, v26.8b \n\t" // widen blue to 16 bits
+
+ "shl v4.8h, v4.8h, #2 \n\t" // src red = src_red << 2 (later will do >> 5 to make 5 bit red)
+ "shl v5.8h, v5.8h, #3 \n\t" // src grn = src_grn << 3 (later will do >> 5 to make 6 bit grn)
+ "shl v6.8h, v6.8h, #2 \n\t" // src blu = src_blu << 2 (later will do >> 5 to make 5 bit blu)
+
+ "movi v21.8h, #1, lsl#8 \n\t" // set up constant 256 (1<<8)
+ "uxtl v14.8h, v27.8b \n\t" // widen alpha to 16 bits
+ "sub v14.8h, v21.8h, v14.8h \n\t" // 256 - sa
+ "ushr v14.8h, v14.8h, #3 \n\t" // (256 - sa) >> 3
+
+ "front: \n\t"
+ "ld1 {v0.8h, v1.8h}, [%[dst]] \n\t" // load sixteen dst RGB565 pixels
+ //set PREFETCH_DISTANCE to 128
+ "prfum pldl1keep, [%[dst], #128] \n\t"
+
+ "subs x1, x1, #1 \n\t" // decrement loop counter
+
+ "shl v9.8h, v0.8h, #5 \n\t" // shift green to top of lanes
+
+ "shl v10.8h, v0.8h, #11 \n\t" // shift blue to top of lanes
+ "ushr v10.8h, v10.8h, #11 \n\t" // extract blue
+
+ "ushr v8.8h, v0.8h, #11 \n\t" // extract red
+ "ushr v9.8h, v9.8h, #10 \n\t" // extract green
+
+ "shl v3.8h, v1.8h, #5 \n\t" // shift green to top of lanes
+
+ "shl v7.8h, v1.8h, #11 \n\t" // shift blue to top of lanes
+ "ushr v7.8h, v7.8h, #11 \n\t" // extract blue
+
+ "ushr v2.8h, v1.8h, #11 \n\t" // extract red
+ "ushr v3.8h, v3.8h, #10 \n\t" // extract green
+
+ //If we use src in mla, directly, vd.8h is updated by mla, so need to calculate src in next loop again, which requires 12 cycles.
+ //Instead, copy src to other registers and use them as a mla destination.
+ //6 shl commands are needed, but we don't need to update src. In total, will get 6 cycle benefit in each loop.
+
+ "shl v15.8h, v4.8h, #0 \n\t" // copy dst 0 red result
+ "shl v16.8h, v5.8h, #0 \n\t" // copy dst 0 grn result
+ "shl v17.8h, v6.8h, #0 \n\t" // copy dst 0 blu result
+ "mla v15.8h, v8.8h, v14.8h \n\t" // dst 0 red result = dst_red * dst_scale
+ "mla v16.8h, v9.8h, v14.8h \n\t" // dst 0 grn result = dst_grn * dst_scale
+ "mla v17.8h, v10.8h, v14.8h \n\t" // dst 0 blu result = dst_blu * dst_scale
+
+ "shl v20.8h, v4.8h, #0 \n\t" // copy dst 1 red result
+ "shl v19.8h, v5.8h, #0 \n\t" // copy dst 1 grn result
+ "shl v18.8h, v6.8h, #0 \n\t" // copy dst 1 blu result
+ "mla v20.8h, v2.8h, v14.8h \n\t" // dst 1 red result = dst_red * dst_scale
+ "mla v19.8h, v3.8h, v14.8h \n\t" // dst 1 grn result = dst_grn * dst_scale
+ "mla v18.8h, v7.8h, v14.8h \n\t" // dst 1 blu result = dst_blu * dst_scale
+
+ "ushr v15.8h, v15.8h, #5 \n\t" // dst 0 red result >> 5
+ "ushr v16.8h, v16.8h, #5 \n\t" // dst 0 grn result >> 5
+ "ushr v17.8h, v17.8h, #5 \n\t" // dst 0 blu result >> 5
+
+ "ushr v20.8h, v20.8h, #5 \n\t" // dst 1 red result >> 5
+ "ushr v19.8h, v19.8h, #5 \n\t" // dst 1 grn result >> 5
+ "ushr v18.8h, v18.8h, #5 \n\t" // dst 1 blu result >> 5
+
+ "sli v17.8h, v16.8h, #5 \n\t" // dst 0 insert green into blue
+ "sli v17.8h, v15.8h, #11 \n\t" // dst 0 insert red into green/blue
+
+ "sli v18.8h, v19.8h, #5 \n\t" // dst 1 insert green into blue
+ "sli v18.8h, v20.8h, #11 \n\t" // dst 1 insert red into green/blue
+
+ "st1 {v17.8h, v18.8h}, [%[dst]], #32 \n\t" // write pixel back to dst 0 and dst 1, update ptr
+ "cbnz x1, front \n\t" // if counter !=0, loop
+ "back: \n\t" // exit
+
+ : [src] "+r" (src), [dst] "+r" (dst), [count] "+r" (count)
+ : : "x1", "x2", "v0", "v1", "v2", "v3", "v4", "v5", "v6", "v7", "v8", "v9", "v10", "v14", "v15", "v16", "v17", "v18", "v19", "v20", "v21",
+ "v24", "v25", "v26", "v27"
+ );
+#else
+ asm volatile (
+ "movs r4, %[count], lsr #4 \n\t" // calc. count>>4
+ "beq 2f \n\t" // if (count>>4) == 0, exit
+ "vmov.u16 q15, #0x1f \n\t" // set up blue mask
+ "vld4.u8 {d24, d25, d26, d27}, [%[src]] \n\t" // load eight src ABGR32 pixels
+
+ "vmov r5, r6, d24 \n\t" // save src red in r5, r6
+ "vmov r7, r8, d25 \n\t" // save src green in r7, r8
+ "vmov r9, r10, d26 \n\t" // save src blue in r9, r10
+ "vmov r11, r12, d27 \n\t" // save src alpha in r11, r12
+
+
+ "1: \n\t"
+ "vld1.u16 {d0, d1, d2, d3}, [%[dst]] \n\t" // load sixteen dst RGB565 pixels
+ //set PREFETCH_DISTANCE to 128
+ "pld [%[dst], #128] \n\t"
+
+ "subs r4, r4, #1 \n\t" // decrement loop counter
+
+ "vmov d24, r5, r6 \n\t" // src red to d24
+ "vmov d25, r7, r8 \n\t" // src green to d25
+ "vmov d26, r9, r10 \n\t" // src blue to d26
+ "vmov d27, r11, r12 \n\t" // src alpha to d27
+
+ "vmov.u16 q3, #256 \n\t" // set up constant
+ "vmovl.u8 q14, d27 \n\t" // widen alpha to 16 bits
+ // dst_scale = q14
+ "vsub.u16 q14, q3, q14 \n\t" // 256 - sa
+ "vshr.u16 q14, q14, #3 \n\t" // (256 - sa) >> 3
+
+
+ // dst_0_rgb = {q8, q9, q10}
+ "vshl.u16 q9, q0, #5 \n\t" // shift green to top of lanes
+ "vand q10, q0, q15 \n\t" // extract blue
+ "vshr.u16 q8, q0, #11 \n\t" // extract red
+ "vshr.u16 q9, q9, #10 \n\t" // extract green
+
+ //use q3 for dst_1 green. In the next loop, needs to set q3 to 256 again.
+ // dst_1_rgb = {q2, q3, q7}
+ "vshl.u16 q3, q1, #5 \n\t" // shift green to top of lanes
+ "vand q7, q1, q15 \n\t" // extract blue
+ "vshr.u16 q2, q1, #11 \n\t" // extract red
+ "vshr.u16 q3, q3, #10 \n\t" // extract green
+
+ // srcrgba = {q4, q5, q6, q14}, alpha calculation is done already in above.
+ // q4, q5, q6 will have each channel's result of dst_1_rgb.
+ "vmovl.u8 q4, d24 \n\t" // widen red to 16 bits
+ "vmovl.u8 q5, d25 \n\t" // widen green to 16 bits
+ "vmovl.u8 q6, d26 \n\t" // widen blue to 16 bits
+
+ // srcrgba = {q11, q12, q13, q14}, alpha calculation is done already in above.
+ // q11, q12, q13 will have each channel's result of dst_0_rgb.
+ "vmovl.u8 q11, d24 \n\t" // widen red to 16 bits
+ "vmovl.u8 q12, d25 \n\t" // widen green to 16 bits
+ "vmovl.u8 q13, d26 \n\t" // widen blue to 16 bits
+
+ "vshl.u16 q11, q11, #2 \n\t" // dst 0 red result = src_red << 2 (later will do >> 5 to make 5 bit red)
+ "vshl.u16 q12, q12, #3 \n\t" // dst 0 grn result = src_grn << 3 (later will do >> 5 to make 6 bit grn)
+ "vshl.u16 q13, q13, #2 \n\t" // dst 0 blu result = src_blu << 2 (later will do >> 5 to make 5 bit blu)
+
+ "vshl.u16 q4, q4, #2 \n\t" // dst 1 red result = src_red << 2 (later will do >> 5 to make 5 bit red)
+ "vshl.u16 q5, q5, #3 \n\t" // dst 1 grn result = src_grn << 3 (later will do >> 5 to make 6 bit grn)
+ "vshl.u16 q6, q6, #2 \n\t" // dst 1 blu result = src_blu << 2 (later will do >> 5 to make 5 bit blu)
+
+ "vmla.u16 q11, q8, q14 \n\t" // dst 0 red result += dst_red * dst_scale
+ "vmla.u16 q12, q9, q14 \n\t" // dst 0 grn result += dst_grn * dst_scale
+ "vmla.u16 q13, q10, q14 \n\t" // dst 0 blu result += dst_blu * dst_scale
+
+ "vmla.u16 q4, q2, q14 \n\t" // dst 1 red result += dst_red * dst_scale
+ "vmla.u16 q5, q3, q14 \n\t" // dst 1 grn result += dst_grn * dst_scale
+ "vmla.u16 q6, q7, q14 \n\t" // dst 1 blu result += dst_blu * dst_scale
+
+ "vshr.u16 q11, q11, #5 \n\t" // dst 0 red result >> 5
+ "vshr.u16 q12, q12, #5 \n\t" // dst 0 grn result >> 5
+ "vshr.u16 q13, q13, #5 \n\t" // dst 0 blu result >> 5
+
+ "vshr.u16 q4, q4, #5 \n\t" // dst 1 red result >> 5
+ "vshr.u16 q5, q5, #5 \n\t" // dst 1 grn result >> 5
+ "vshr.u16 q14, q6, #5 \n\t" // dst 1 blu result >> 5
+
+ "vsli.u16 q13, q12, #5 \n\t" // dst 0 insert green into blue
+ "vsli.u16 q13, q11, #11 \n\t" // dst 0 insert red into green/blue
+
+ "vsli.u16 q14, q5, #5 \n\t" // dst 1 insert green into blue
+ "vsli.u16 q14, q4, #11 \n\t" // dst 1 insert red into green/blue
+
+ "vst1.16 {d26, d27, d28, d29}, [%[dst]]! \n\t" // write pixel back to dst 0 and dst 1, update ptr
+
+ "bne 1b \n\t" // if counter != 0, loop
+ "2: \n\t" // exit
+
+ : [src] "+r" (src), [dst] "+r" (dst), [count] "+r" (count)
+ :
+ : "cc", "memory", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12",
+ "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7", "d8", "d9", "d10", "d11", "d12", "d13", "d14", "d15", "d16",
+ "d17", "d18", "d19", "d20", "d21", "d22", "d23", "d24", "d25", "d26", "d27", "d28", "d29", "d30", "d31"
+ );
+#endif
+ count &= 0xF;
+ if (count > 0) {
+ do {
+ uint32_t dst_expand = SkExpand_rgb_16(*dst) * scale;
+ *dst = SkCompact_rgb_16((src_expand + dst_expand) >> 5);
+ dst += 1;
+ } while (--count != 0);
+ }
+}
+
static inline uint16x8_t SkDiv255Round_neon8(uint16x8_t prod) {
prod += vdupq_n_u16(128);
prod += vshrq_n_u16(prod, 8);
« no previous file with comments | « src/opts/SkBlitRow_opts_arm_neon.h ('k') | src/opts/SkBlitRow_opts_mips_dsp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698