Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 845193005: Tear down ContentVideoView from content-layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded include Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index d42d8544372a7b5c2710aac9037ddf2f70e83f25..f17a6e5a6786ce00dd4dfc9551ee4310ae2541b0 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -21,7 +21,6 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/browser/web_contents_delegate.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
#include "media/base/android/media_player_bridge.h"
@@ -136,8 +135,6 @@ BrowserMediaPlayerManager::~BrowserMediaPlayerManager() {
}
void BrowserMediaPlayerManager::ExitFullscreen(bool release_media_player) {
- if (WebContentsDelegate* delegate = web_contents_->GetDelegate())
Ignacio Solla 2015/01/26 10:55:57 is this intentional? Don't we still need it?
Hugo Holgersson 2015/01/26 11:02:33 It is intentional. WebContentsImpl::ExitFullscreen
- delegate->ExitFullscreenModeForTab(web_contents_);
if (RenderWidgetHostViewAndroid* view_android =
static_cast<RenderWidgetHostViewAndroid*>(
web_contents_->GetRenderWidgetHostView())) {

Powered by Google App Engine
This is Rietveld 408576698