Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2868)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java

Issue 845193005: Tear down ContentVideoView from content-layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded include Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
index b706c6f6ff3dde66ceaa05652c5dd377297b4003..2243accf1033b20f7744bef5f94a37a54e3dcfd3 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
@@ -267,6 +267,11 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
// We need to wait because the surface view is first transfered, and then removed
// asynchronously.
VideoSurfaceViewUtils.waitAndAssertContainsZeroVideoHoleSurfaceViews(this, customView);
+
+ // Exit fullscreen and verify that the video hole surface is re-created.
+ DOMUtils.exitFullscreen(mContentViewCore.getWebContents());
+ VideoSurfaceViewUtils.pollAndAssertContainsOneVideoHoleSurfaceView(this,
+ mTestContainerView);
}
@MediumTest
@@ -478,6 +483,7 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
}
}
}));
+ // TODO: Test that inline video is actually displayed.
mkosiba (inactive) 2015/01/26 12:03:05 do we have a bug tracking this?
Hugo Holgersson 2015/01/26 14:37:36 Done. I created crbug.com/451995 for this.
}
private void assertContainsContentVideoView() throws Exception {

Powered by Google App Engine
This is Rietveld 408576698