Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 845063002: Add result logging for TCP and SSL connection setup. (Closed)

Created:
5 years, 11 months ago by Kevin M
Modified:
5 years, 11 months ago
Reviewers:
mark a. foltz, Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add result logging for TCP and SSL connection setup. BUG= Committed: https://crrev.com/8190d385901715f86cbd7c3703f93ea79a42d457 Cr-Commit-Position: refs/heads/master@{#311585}

Patch Set 1 #

Patch Set 2 : Merge with master. #

Patch Set 3 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M extensions/browser/api/cast_channel/cast_socket.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/common/api/cast_channel/logging.proto View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
mark a. foltz
lgtm
5 years, 11 months ago (2015-01-13 01:42:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845063002/1
5 years, 11 months ago (2015-01-13 03:05:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35391)
5 years, 11 months ago (2015-01-13 03:13:48 UTC) #6
Kevin M
+finnur for logging proto change. Thanks!
5 years, 11 months ago (2015-01-13 23:18:37 UTC) #8
Finnur
Not familiar with this code, but I assume you are looking for an OWNERS approval ...
5 years, 11 months ago (2015-01-14 11:48:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845063002/20001
5 years, 11 months ago (2015-01-14 20:59:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/113735) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/37393) android_chromium_gn_compile_dbg ...
5 years, 11 months ago (2015-01-14 21:04:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845063002/40001
5 years, 11 months ago (2015-01-14 22:42:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-15 00:21:26 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:22:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8190d385901715f86cbd7c3703f93ea79a42d457
Cr-Commit-Position: refs/heads/master@{#311585}

Powered by Google App Engine
This is Rietveld 408576698