Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: extensions/browser/api/cast_channel/cast_socket.cc

Issue 845063002: Add result logging for TCP and SSL connection setup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/api/cast_channel/logging.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/cast_channel/cast_socket.cc
diff --git a/extensions/browser/api/cast_channel/cast_socket.cc b/extensions/browser/api/cast_channel/cast_socket.cc
index 8fc457040fae5f7e77b1ccf777dd4f348626d5e4..74f3cf1463e1313baa4f4cb67345ad58794099e3 100644
--- a/extensions/browser/api/cast_channel/cast_socket.cc
+++ b/extensions/browser/api/cast_channel/cast_socket.cc
@@ -379,6 +379,8 @@ int CastSocketImpl::DoTcpConnect() {
int CastSocketImpl::DoTcpConnectComplete(int connect_result) {
VLOG_WITH_CONNECTION(1) << "DoTcpConnectComplete: " << connect_result;
+ logger_->LogSocketEventWithRv(channel_id_, proto::TCP_SOCKET_CONNECT_COMPLETE,
+ connect_result);
if (connect_result == net::OK) {
// Enable TCP-level keep-alive handling.
// TODO(kmarshall): Remove TCP keep-alive once protocol-level ping handling
@@ -407,6 +409,8 @@ int CastSocketImpl::DoSslConnect() {
}
int CastSocketImpl::DoSslConnectComplete(int result) {
+ logger_->LogSocketEventWithRv(channel_id_, proto::SSL_SOCKET_CONNECT_COMPLETE,
+ result);
VLOG_WITH_CONNECTION(1) << "DoSslConnectComplete: " << result;
if (result == net::ERR_CERT_AUTHORITY_INVALID &&
peer_cert_.empty() && ExtractPeerCert(&peer_cert_)) {
« no previous file with comments | « no previous file | extensions/common/api/cast_channel/logging.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698