Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
844913004:
reorg filter quality cascade (Closed)
Descriptionreorg filter quality cascade
BUG=skia:
NOTREECHECKS=True
Committed: https://skia.googlesource.com/skia/+/f7094c4ed01d500f31b993ed2620c2737093e383
Patch Set 1 #Patch Set 2 : #Patch Set 3 : add legacy compile guard #Patch Set 4 : add suppression #
Total comments: 8
Patch Set 5 : fix spelling, use matrix directly instead of unit-vectors" #Patch Set 6 : re-reverse skew X/Y #Patch Set 7 : add dox #
Total comments: 5
Patch Set 8 : more misspelling #
Messages
Total messages: 36 (16 generated)
WIP - will generate slight image differences.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-01-15 04:33 UTC
The CQ bit was unchecked by reed@google.com
reed@google.com changed reviewers: + humper@google.com, robertphillips@google.com
- reorg for clarity - fix some quality bugs (e.g. subpixel position of HQ) - explore alternatives to scanline-hq [ SVG, mipmap, etc. ]
The CQ bit was checked by reed@google.com
needs https://codereview.chromium.org/850323004/ for chrome
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-01-16 23:17 UTC
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-01-16 23:26 UTC
The CQ bit was checked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/60001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-01-16 23:35 UTC
The CQ bit was unchecked by robertphillips@google.com
lgtm + questions (and typos) https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:284: static bool extract_scale(const SkMatrix& matrix, SkVector* scale) { SkASSERT(!matrix.hasPerspective()); ? assert that it has the affine flag set ? https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:297: Is there someplace central we can document what we do in our filtering cascade? Do we unit test SkBitmapProcState at all? https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:300: reqeust ? valide ? https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:355: reqeust ? valide ?
https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:284: static bool extract_scale(const SkMatrix& matrix, SkVector* scale) { On 2015/01/16 18:37:01, robertphillips wrote: > SkASSERT(!matrix.hasPerspective()); ? > assert that it has the affine flag set ? Done. https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:297: On 2015/01/16 18:37:00, robertphillips wrote: > Is there someplace central we can document what we do in our filtering cascade? > Do we unit test SkBitmapProcState at all? Will add comment above chooseProcs() https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:300: On 2015/01/16 18:37:01, robertphillips wrote: > reqeust ? valide ? Done. https://codereview.chromium.org/844913004/diff/60001/src/core/SkBitmapProcSta... src/core/SkBitmapProcState.cpp:355: On 2015/01/16 18:37:01, robertphillips wrote: > reqeust ? > valide ? Done.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/80001
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/120001
lgtm + some typos https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... src/core/SkBitmapProcState.cpp:297: /* implemented https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... src/core/SkBitmapProcState.cpp:471: * - else we downgrade to the next lower level and try again. fulfill https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... src/core/SkBitmapProcState.cpp:472: * We can always fullfil requests for Low and None and given ?
The CQ bit was unchecked by reed@google.com
https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... src/core/SkBitmapProcState.cpp:297: /* On 2015/01/16 19:45:00, robertphillips wrote: > implemented Done. https://codereview.chromium.org/844913004/diff/120001/src/core/SkBitmapProcSt... src/core/SkBitmapProcState.cpp:472: * We can always fullfil requests for Low and None On 2015/01/16 19:45:00, robertphillips wrote: > and given ? Done.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/140001
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913004/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/f7094c4ed01d500f31b993ed2620c2737093e383 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
