Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 844913003: Move XferEffects class to GrCustomXfermode file (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@arithXP
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move XferEffects class to GrCustomXfermode file BUG=skia: Committed: https://skia.googlesource.com/skia/+/0063a9b69a6a5d377f207c2aa1ea1e7220c19ba9

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Move functions #

Patch Set 4 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+581 lines, -470 lines) Patch
M gyp/gpu.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A include/gpu/effects/GrCustomXfermode.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 chunks +4 lines, -470 lines 0 comments Download
A src/gpu/effects/GrCustomXfermode.cpp View 1 2 3 1 chunk +492 lines, -0 lines 0 comments Download
A src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
egdaniel
This CL is in preparation for adding in the XP for all xfermodes originally implemented ...
5 years, 11 months ago (2015-01-14 19:19:45 UTC) #2
egdaniel
ping
5 years, 11 months ago (2015-01-15 16:54:24 UTC) #3
bsalomon
On 2015/01/15 16:54:24, egdaniel wrote: > ping lgtm, but wondering if we need Priv in ...
5 years, 11 months ago (2015-01-15 17:04:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913003/40001
5 years, 11 months ago (2015-01-15 18:35:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1507)
5 years, 11 months ago (2015-01-15 18:36:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913003/60001
5 years, 11 months ago (2015-01-15 18:43:30 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 18:52:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0063a9b69a6a5d377f207c2aa1ea1e7220c19ba9

Powered by Google App Engine
This is Rietveld 408576698