Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 84483002: [telemetry] Fix types and type checks of numeric results. (Closed)

Created:
7 years, 1 month ago by dtu
Modified:
7 years, 1 month ago
Reviewers:
nduca, shadi
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Fix types and type checks of numeric results. Followup for http://crrev.com/236907 BUG=None. TEST=None. TBR=nduca Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/media.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dtu
Committed patchset #1 manually as r236951.
7 years, 1 month ago (2013-11-23 18:23:06 UTC) #1
nduca
7 years, 1 month ago (2013-11-24 06:17:36 UTC) #2
Message was sent while issue was closed.
Thanks Dave, sorry about that!

Powered by Google App Engine
This is Rietveld 408576698