Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tools/telemetry/telemetry/value/scalar.py

Issue 84483002: [telemetry] Fix types and type checks of numeric results. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/scalar.py
diff --git a/tools/telemetry/telemetry/value/scalar.py b/tools/telemetry/telemetry/value/scalar.py
index 397dae46acf7151f4562c9faa1fa97c9995dfc54..8fec048c93b58b719eac6d2913d3482d56e5a089 100644
--- a/tools/telemetry/telemetry/value/scalar.py
+++ b/tools/telemetry/telemetry/value/scalar.py
@@ -1,6 +1,9 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
+import numbers
+
from telemetry.value import Value
from telemetry.value.list_of_scalar_values import ListOfScalarValues
@@ -13,7 +16,7 @@ class ScalarValue(Value):
ScalarValue(page, 'num_dom_elements', 'count', num_elements)
"""
super(ScalarValue, self).__init__(page, name, units, important)
- assert isinstance(value, int) or isinstance(value, float)
+ assert isinstance(value, numbers.Number)
self.value = value
def __repr__(self):
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698