ash/shell_observer.h - Issue 844763006: Change overview mode to so that docked panel windows are not grouped together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell_observer.h

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed stale pointer in ScopedTransformOverviewWindow. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell_observer.h

diff --git a/ash/shell_observer.h b/ash/shell_observer.h

index 35b255560d9d94eaac77c788ba6b0a58a253b094..901c25aa6bbdd7f1195a8d5bf58c30ae80e7b7de 100644

--- a/ash/shell_observer.h

+++ b/ash/shell_observer.h

@@ -49,9 +49,8 @@ class ASH_EXPORT ShellObserver {

// get re-arranged).

virtual void OnOverviewModeStarting() {}

- // Called before the overview mode is ending (before the windows get arranged

- // to their final position).

- virtual void OnOverviewModeEnding() {}

+ // Called after overview mode has ended.

+ virtual void OnOverviewModeEnded() {}

// Called when the always maximize mode has started. Windows might still

// animate though.

« no previous file with comments | « ash/shell.cc ('k') | ash/system/overview/overview_button_tray.h » ('j') | no next file with comments »