ash/shell.cc - Issue 844763006: Change overview mode to so that docked panel windows are not grouped together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell.cc

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed stale pointer in ScopedTransformOverviewWindow. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell.cc

diff --git a/ash/shell.cc b/ash/shell.cc

index 9062d81afef808035530897d9c50fbcfab07187f..e55a7e3d067efe454f7470a3ecb240941567879a 100644

--- a/ash/shell.cc

+++ b/ash/shell.cc

@@ -420,8 +420,8 @@ void Shell::OnOverviewModeStarting() {

FOR_EACH_OBSERVER(ShellObserver, observers_, OnOverviewModeStarting());

}

-void Shell::OnOverviewModeEnding() {

- FOR_EACH_OBSERVER(ShellObserver, observers_, OnOverviewModeEnding());

+void Shell::OnOverviewModeEnded() {

+ FOR_EACH_OBSERVER(ShellObserver, observers_, OnOverviewModeEnded());

}

void Shell::OnMaximizeModeStarted() {

« no previous file with comments | « ash/shell.h ('k') | ash/shell_observer.h » ('j') | no next file with comments »