Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 844443002: [sql] Test that a Chromium fts change is actually in place. (Closed)

Created:
5 years, 11 months ago by Scott Hess - ex-Googler
Modified:
5 years, 11 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Test that a Chromium fts change is actually in place. In working on a new import of SQLite, I found the patch resulting from: http://codereview.chromium.org/14176 This only touches fts2, not fts3. These tests verify that both versions work in the way the patch implies. BUG=340757 Committed: https://crrev.com/355d9a1e3cfc8e40eec3f3b0aae9e8baeb4ae14d Cr-Commit-Position: refs/heads/master@{#310922}

Patch Set 1 #

Patch Set 2 : Oops, iOS doesn't have the stuff being tested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M sql/sqlite_features_unittest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Scott Hess - ex-Googler
I don't think we actually use fts anywhere these days, but that's a problem for ...
5 years, 11 months ago (2015-01-07 00:47:03 UTC) #2
michaeln
lgtm
5 years, 11 months ago (2015-01-09 00:44:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844443002/1
5 years, 11 months ago (2015-01-09 18:32:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/36025) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/47531)
5 years, 11 months ago (2015-01-09 18:56:19 UTC) #7
Scott Hess - ex-Googler
On 2015/01/09 18:56:19, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-09 23:53:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844443002/20001
5 years, 11 months ago (2015-01-09 23:55:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-10 00:42:56 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 00:44:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/355d9a1e3cfc8e40eec3f3b0aae9e8baeb4ae14d
Cr-Commit-Position: refs/heads/master@{#310922}

Powered by Google App Engine
This is Rietveld 408576698