Issue 14176: Change sqlite fts2 tokenizer to recognize "foo*" as a prefix search, and not...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14176: Change sqlite fts2 tokenizer to recognize "foo*" as a prefix search, and not... (Closed)

Created:
12 years ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change sqlite fts2 tokenizer to recognize "foo*" as a prefix search, and not "foo *". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7115

Patch Set 1 #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	third_party/sqlite/fts2.c	View		2 chunks	+5 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/14176/diff/1/2 File third_party/sqlite/fts2.c (right): http://codereview.chromium.org/14176/diff/1/2#newcode3571 Line 3571: iEndLast==iBegin){ tabbing off here? is iEndLast supposed ...

12 years ago (2008-12-17 00:28:11 UTC) #2

Matt Perry

12 years ago (2008-12-17 00:29:58 UTC) #3

http://codereview.chromium.org/14176/diff/1/2
File third_party/sqlite/fts2.c (right):

http://codereview.chromium.org/14176/diff/1/2#newcode3571
Line 3571: iEndLast==iBegin){
On 2008/12/17 00:28:11, Evan Martin wrote:
> tabbing off here?

fixed.. though there doesn't seem to be a consistent way to indent here.

> is iEndLast supposed to be one past the end of the previous token?  i'm a
little
> surprised if this works otherwise.

it seems that way.

Expand Messages | Collapse Messages