Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 844433004: Add Contributing to Skia section of docs (Closed)

Created:
5 years, 11 months ago by hcm
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Contributing to Skia section of docs BUG=skia: Committed: https://skia.googlesource.com/skia/+/fd1ad48d4d9073b90f58e60219637046a8446267

Patch Set 1 #

Patch Set 2 : Fix formatting, consolidate #

Patch Set 3 : Fun with bullets #

Patch Set 4 : more fun with bullets #

Patch Set 5 : no more colons #

Patch Set 6 : fix code block #

Total comments: 2

Patch Set 7 : word wrap and title update #

Total comments: 1

Patch Set 8 : fix line wrap to 80 cols #

Patch Set 9 : small fix to style guide date formatting #

Total comments: 4

Patch Set 10 : prettify code #

Patch Set 11 : prettify take 2 #

Patch Set 12 : fix code block on flatten page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1129 lines, -0 lines) Patch
A site/dev/contrib/cqkeywords.md View 1 2 3 4 5 6 1 chunk +96 lines, -0 lines 0 comments Download
A site/dev/contrib/flatten.md View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +88 lines, -0 lines 0 comments Download
A site/dev/contrib/index.md View 1 2 3 4 5 6 7 1 chunk +48 lines, -0 lines 0 comments Download
A site/dev/contrib/patch.md View 1 2 3 4 5 6 7 1 chunk +72 lines, -0 lines 0 comments Download
A site/dev/contrib/revert.md View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A site/dev/contrib/style.md View 1 2 3 4 5 6 7 8 9 10 1 chunk +559 lines, -0 lines 0 comments Download
A site/dev/contrib/submit.md View 1 2 3 4 5 6 7 8 9 10 1 chunk +248 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
hcm
On 2015/01/20 16:48:03, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:jcgregorio@google.com Side note: Pages ...
5 years, 11 months ago (2015-01-20 16:49:56 UTC) #2
jcgregorio
https://codereview.chromium.org/844433004/diff/100001/site/dev/contrib/cqkeywords.md File site/dev/contrib/cqkeywords.md (right): https://codereview.chromium.org/844433004/diff/100001/site/dev/contrib/cqkeywords.md#newcode7 site/dev/contrib/cqkeywords.md:7: If you want to test your CL through the ...
5 years, 11 months ago (2015-01-20 17:59:00 UTC) #3
hcm
On 2015/01/20 17:59:00, jcgregorio wrote: > https://codereview.chromium.org/844433004/diff/100001/site/dev/contrib/cqkeywords.md > File site/dev/contrib/cqkeywords.md (right): > > https://codereview.chromium.org/844433004/diff/100001/site/dev/contrib/cqkeywords.md#newcode7 > ...
5 years, 11 months ago (2015-01-21 03:38:12 UTC) #4
jcgregorio
https://codereview.chromium.org/844433004/diff/120001/site/dev/contrib/flatten.md File site/dev/contrib/flatten.md (right): https://codereview.chromium.org/844433004/diff/120001/site/dev/contrib/flatten.md#newcode4 site/dev/contrib/flatten.md:4: Many objects in Skia, such as SkShaders and other ...
5 years, 11 months ago (2015-01-21 13:15:23 UTC) #5
hcm
On 2015/01/21 13:15:23, jcgregorio wrote: > https://codereview.chromium.org/844433004/diff/120001/site/dev/contrib/flatten.md > File site/dev/contrib/flatten.md (right): > > https://codereview.chromium.org/844433004/diff/120001/site/dev/contrib/flatten.md#newcode4 > ...
5 years, 11 months ago (2015-01-21 16:49:48 UTC) #6
jcgregorio
https://codereview.chromium.org/844433004/diff/160001/site/dev/contrib/flatten.md File site/dev/contrib/flatten.md (right): https://codereview.chromium.org/844433004/diff/160001/site/dev/contrib/flatten.md#newcode12 site/dev/contrib/flatten.md:12: ~~~~ Add prettify before all the code sections in ...
5 years, 11 months ago (2015-01-21 17:55:39 UTC) #7
hcm
On 2015/01/21 17:55:39, jcgregorio wrote: > https://codereview.chromium.org/844433004/diff/160001/site/dev/contrib/flatten.md > File site/dev/contrib/flatten.md (right): > > https://codereview.chromium.org/844433004/diff/160001/site/dev/contrib/flatten.md#newcode12 > ...
5 years, 11 months ago (2015-01-21 19:23:53 UTC) #8
jcgregorio
On 2015/01/21 19:23:53, hcm wrote: > On 2015/01/21 17:55:39, jcgregorio wrote: > > > https://codereview.chromium.org/844433004/diff/160001/site/dev/contrib/flatten.md ...
5 years, 11 months ago (2015-01-21 19:32:11 UTC) #9
hcm
On 2015/01/21 19:32:11, jcgregorio wrote: > On 2015/01/21 19:23:53, hcm wrote: > > On 2015/01/21 ...
5 years, 11 months ago (2015-01-21 19:54:37 UTC) #10
jcgregorio
lgtm
5 years, 11 months ago (2015-01-21 19:54:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844433004/210001
5 years, 11 months ago (2015-01-21 19:55:53 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 20:05:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #12 (id:210001) as
https://skia.googlesource.com/skia/+/fd1ad48d4d9073b90f58e60219637046a8446267

Powered by Google App Engine
This is Rietveld 408576698