Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 844433003: Revert "Generate some of the C++ bindings for mojom tagged unions." (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
Reviewers:
jamesr, azani
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Generate some of the C++ bindings for mojom tagged unions." This reverts commit 518d1f58c19aebdb0f09736a5f9016b8d9c4ea1b. The generated code does not compile on VC2013. See for example: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/141/steps/compile/logs/stdio BUG=None R=jamesr@chromium.org TBR=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9d3b8dd17f12d20035a14737fdc38dd926890ff8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -186 lines) Patch
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 3 chunks +0 lines, -13 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 4 chunks +0 lines, -16 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 3 chunks +1 line, -24 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/serialization_macros.tmpl View 1 chunk +0 lines, -7 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 chunk +0 lines, -26 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 4 chunks +0 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -6 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 3 chunks +2 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/tools/bindings/pylib/mojom_tests/generate/generator_unittest.py View 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/translate_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-15 22:44:32 UTC) #1
jamesr
lgtm
5 years, 11 months ago (2015-01-15 22:46:15 UTC) #2
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-15 22:49:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d3b8dd17f12d20035a14737fdc38dd926890ff8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698