Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

Issue 844433003: Revert "Generate some of the C++ bindings for mojom tagged unions." (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
index 96fa4f9765251a12a5128213cafa13908a07e530..1ddcc45c39dde0f3b5a783901c988ec10c8a0942 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
@@ -24,7 +24,6 @@
#include "mojo/public/cpp/bindings/lib/string_serialization.h"
#include "mojo/public/cpp/bindings/lib/validate_params.h"
#include "mojo/public/cpp/bindings/lib/validation_errors.h"
-#include "mojo/public/cpp/bindings/lib/union_accessor.h"
#include "mojo/public/cpp/environment/logging.h"
{%- for namespace in namespaces_as_array %}
@@ -64,11 +63,6 @@ const uint32_t {{method_name}} = {{method.ordinal}};
{%- include "struct_definition.tmpl" %}
{%- endfor %}
-{#--- Union definitions #}
-{% for union in unions %}
-{%- include "union_definition.tmpl" %}
-{%- endfor %}
-
} // namespace internal
{#--- Struct Constants #}
@@ -83,11 +77,6 @@ const {{constant.kind|cpp_pod_type}} {{struct.name}}::{{constant.name}} = {{cons
{%- include "wrapper_class_definition.tmpl" %}
{%- endfor %}
-{#--- Union builder definitions #}
-{%- for union in unions %}
-{%- include "wrapper_union_class_definition.tmpl" %}
-{%- endfor %}
-
{#--- Interface definitions #}
{%- for interface in interfaces %}
{%- include "interface_definition.tmpl" %}
@@ -98,11 +87,6 @@ const {{constant.kind|cpp_pod_type}} {{struct.name}}::{{constant.name}} = {{cons
{%- include "struct_serialization_definition.tmpl" %}
{%- endfor %}
-{#--- Union Serialization Helpers #}
-{%- for union in unions %}
-{%- include "union_serialization_definition.tmpl" %}
-{%- endfor %}
-
{%- for namespace in namespaces_as_array|reverse %}
} // namespace {{namespace}}
{%- endfor %}

Powered by Google App Engine
This is Rietveld 408576698