Issue 84423002: Correctly resolve empty script URLs in Worker constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 84423002: Correctly resolve empty script URLs in Worker constructors. (Closed)

Created:
7 years, 1 month ago by sof

Modified:
7 years ago

Reviewers:
kinuko, Hajime Morrita, jochen (gone - plz use gerrit), adamk

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Correctly resolve empty script URLs in Worker constructors. When creating workers via thei constructors, the spec permits empty strings to be given to the URL resolution step, http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dedicated-workers-and-the-worker-interface (or http://dev.w3.org/html5/workers/#dedicated-workers-and-the-worker-interface .) [ The shared worker case just below has the same resolution step. ] Resolving such an URL should result in the base URL being returned. Align with this, and drop restriction on the string having to be non-empty. This mirrors how Gecko, Trident and Presto behaves. It also aligns with how importScripts() behaves when resolving its arguments. R= BUG=301575 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162624

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -11 lines)			Patch
M	LayoutTests/fast/workers/worker-constructor.html	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/workers/worker-constructor-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/workers/shared-worker-invalid-url.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/workers/worker-invalid-url.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/AbstractWorker.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Hajime Morrita

On 2013/11/23 10:06:36, sof wrote: > At your leisure, please have a look. lgtm.

7 years ago (2013-11-25 03:45:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/84423002/1

7 years ago (2013-11-25 12:13:05 UTC) #3

Message was sent while issue was closed.

Change committed as 162624