Source/core/workers/AbstractWorker.cpp - Issue 84423002: Correctly resolve empty script URLs in Worker constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/AbstractWorker.cpp

Issue 84423002: Correctly resolve empty script URLs in Worker constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/workers/AbstractWorker.cpp

diff --git a/Source/core/workers/AbstractWorker.cpp b/Source/core/workers/AbstractWorker.cpp

index 9250d47d9e44d2a28b1336e48388f7ba9ab274cc..301cdf9289c0855915af2aae3ec82890fa77c3c2 100644

--- a/Source/core/workers/AbstractWorker.cpp

+++ b/Source/core/workers/AbstractWorker.cpp

@@ -51,11 +51,6 @@ AbstractWorker::~AbstractWorker()

KURL AbstractWorker::resolveURL(const String& url, ExceptionState& exceptionState)

{

- if (url.isEmpty()) {

- exceptionState.throwDOMException(SyntaxError, "Failed to create a worker: an empty URL was provided.");

- return KURL();

- }

// FIXME: This should use the dynamic global scope (bug #27887)

KURL scriptURL = executionContext()->completeURL(url);

if (!scriptURL.isValid()) {

« no previous file with comments | « LayoutTests/http/tests/workers/worker-invalid-url.html ('k') | no next file » | no next file with comments »