Revert current time clamp on ended; clamp paused time instead.

Revert current time clamp on ended; clamp paused time instead.

Clamping the current time within Pipeline leads to a race
a race condition while using |renderer_ended_|.  The problem
that code was added for can mostly be fixed by instead clamping
the pause time in WebMediaPlayerImpl.

I've verified the HTMLMediaElement cleanup in another CL still
passes all tests: https://codereview.chromium.org/456343002/

BUG=446637
TEST=layout tests, unittests.

Committed: https://crrev.com/2e50e6f660c9fb42f3f63c127aae2c66b054341d
Cr-Commit-Position: refs/heads/master@{#310686}

[DaleCurtis, 2015-01-08 21:40:33]

Patchset #1 (id:1) has been deleted

[DaleCurtis, 2015-01-08 22:13:31]

Patchset #1 (id:20001) has been deleted

[DaleCurtis, 2015-01-08 22:15:08]

dalecurtis@chromium.org changed reviewers:
+ srirama.m@samsung.com, xhwang@chromium.org

[xhwang, 2015-01-08 22:44:50]

LG, just have one question.

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1034: if (paused_) {
I felt it more clear to keep the |paused_| check out of this function, i.e. only
UpdatePausedTime() when |paused_|. WDYT?

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1036: ended_ ? pipeline_.GetMediaDuration() :
pipeline_.GetMediaTime();
Hmm, please remind me in what case can |ended_| be true?

[DaleCurtis, 2015-01-08 23:16:41]

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1034: if (paused_) {
On 2015/01/08 22:44:50, xhwang wrote:
> I felt it more clear to keep the |paused_| check out of this function, i.e.
only
> UpdatePausedTime() when |paused_|. WDYT?

Done.

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1036: ended_ ? pipeline_.GetMediaDuration() :
pipeline_.GetMediaTime();
On 2015/01/08 22:44:50, xhwang wrote:
> Hmm, please remind me in what case can |ended_| be true?

pause() is always called upon ended from HTMLMediaElement::UpdatePlayState(). 
Which leads to the issues srirama mentions in the first comment on
https://codereview.chromium.org/740663002

[xhwang, 2015-01-08 23:26:19]

LGTM % nit

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1036: ended_ ? pipeline_.GetMediaDuration() :
pipeline_.GetMediaTime();
On 2015/01/08 23:16:41, DaleCurtis wrote:
> On 2015/01/08 22:44:50, xhwang wrote:
> > Hmm, please remind me in what case can |ended_| be true?
> 
> pause() is always called upon ended from HTMLMediaElement::UpdatePlayState(). 
> Which leads to the issues srirama mentions in the first comment on
> https://codereview.chromium.org/740663002

Thanks for the info! Maybe add a comment to make this clear?

[DaleCurtis, 2015-01-08 23:41:53]

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/843863002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:1036: ended_ ? pipeline_.GetMediaDuration() :
pipeline_.GetMediaTime();
On 2015/01/08 23:26:19, xhwang wrote:
> On 2015/01/08 23:16:41, DaleCurtis wrote:
> > On 2015/01/08 22:44:50, xhwang wrote:
> > > Hmm, please remind me in what case can |ended_| be true?
> > 
> > pause() is always called upon ended from
HTMLMediaElement::UpdatePlayState(). 
> > Which leads to the issues srirama mentions in the first comment on
> > https://codereview.chromium.org/740663002
> 
> Thanks for the info! Maybe add a comment to make this clear?

Done.

[DaleCurtis, 2015-01-09 00:17:36]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2015-01-09 00:19:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/843863002/80001

[commit-bot: I haz the power, 2015-01-09 02:43:21]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-01-09 02:44:09]

Patchset 3 (id:??) landed as
https://crrev.com/2e50e6f660c9fb42f3f63c127aae2c66b054341d
Cr-Commit-Position: refs/heads/master@{#310686}