media/blink/webmediaplayer_impl.h - Issue 843863002: Revert current time clamp on ended; clamp paused time instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 843863002: Revert current time clamp on ended; clamp paused time instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index db540f68910eddd8669582481547f21a7732326a..6e8de1f8d57f4d5d248ae83d7d624db576367a84 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -218,6 +218,10 @@ class MEDIA_EXPORT WebMediaPlayerImpl

void OnCdmAttached(blink::WebContentDecryptionModuleResult result,

bool success);

+ // Updates |paused_time_| to the current media time with consideration for the

+ // |ended_| state by clamping current time to duration upon |ended_|.

+ void UpdatePausedTime();

blink::WebLocalFrame* frame_;

// TODO(hclam): get rid of these members and read from the pipeline directly.

« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »