Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 843713002: Revert "Use Xvfb in isolated testing only if use_x11 is set" (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 11 months ago
Reviewers:
spang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, tdresser+watch_chromium.org, peter+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, kalyank, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jdduke+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use Xvfb in isolated testing only if use_x11 is set" This reverts commit 8a7be0714892c0c6360c45d0d602c119873b468e. We've been seeing a problem with tab_capture_end2end_tests taking too much time on linux_gpu_triggered_tests (over 1 hour as opposed to below 30 seconds). This was traced to wrong command on the isolate server, as can be seen e.g. with [1] (good) and [2] (bad). From builder history I was able to narrow down suspect revision range to just cafcab99f5ea (good) [3] and 8a7be0714892 (bad) [4]. There are only two CLs in that range, https://codereview.chromium.org/841693004 and https://codereview.chromium.org/813363003 . First one is just a histogram description change, while the latter changes *.isolate files, which is much more suspect. [1] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=13030c2ece3e5467ba858a978c685865181d32a6 [2] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=104dec9bff0fc701eac105a80d7d64be5b43b033 [3] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97223 [4] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97224 TBR=spang BUG=440882 Committed: https://chromium.googlesource.com/chromium/src/+/99ef9b4892ce79eef6f758cad66de092a72e9bc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -209 lines) Patch
M ash/ash_unittests.isolate View 2 chunks +10 lines, -14 lines 0 comments Download
M base/base_unittests.isolate View 3 chunks +19 lines, -13 lines 0 comments Download
M build/android/pylib/utils/isolator.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/isolate.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser_tests.isolate View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/unit_tests.isolate View 3 chunks +18 lines, -18 lines 0 comments Download
M content/content_browsertests.isolate View 3 chunks +18 lines, -18 lines 0 comments Download
M content/content_unittests.isolate View 3 chunks +21 lines, -17 lines 0 comments Download
M ui/app_list/app_list_unittests.isolate View 3 chunks +16 lines, -16 lines 0 comments Download
M ui/base/ui_base_unittests.isolate View 3 chunks +16 lines, -16 lines 0 comments Download
M ui/events/events_unittests.isolate View 3 chunks +15 lines, -15 lines 0 comments Download
M ui/message_center/message_center_unittests.isolate View 3 chunks +16 lines, -16 lines 0 comments Download
M ui/touch_selection/ui_touch_selection_unittests.isolate View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99ef9b4892ce79eef6f758cad66de092a72e9bc1 Cr-Commit-Position: refs/heads/master@{#310464}
5 years, 11 months ago (2015-01-08 09:35:42 UTC) #1
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 99ef9b4892ce79eef6f758cad66de092a72e9bc1 (presubmit successful).
5 years, 11 months ago (2015-01-08 09:35:45 UTC) #2
Paweł Hajdan Jr.
TBR
5 years, 11 months ago (2015-01-08 09:36:07 UTC) #4
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-08 10:18:19 UTC) #5
Message was sent while issue was closed.
FWIW this revert seems to have helped, see e.g.
http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...

Powered by Google App Engine
This is Rietveld 408576698