Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5501)

Unified Diff: chrome/sync_integration_tests.isolate

Issue 843713002: Revert "Use Xvfb in isolated testing only if use_x11 is set" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/interactive_ui_tests.isolate ('k') | chrome/unit_tests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/sync_integration_tests.isolate
diff --git a/chrome/sync_integration_tests.isolate b/chrome/sync_integration_tests.isolate
index 20640c7403d4494a0a5a6aa24b274534e8e196d8..3c5e0e1f544455dd064880af90c08b28dbb7e507 100644
--- a/chrome/sync_integration_tests.isolate
+++ b/chrome/sync_integration_tests.isolate
@@ -3,15 +3,7 @@
# found in the LICENSE file.
{
'conditions': [
- ['use_x11==0', {
- 'variables': {
- 'command': [
- '<(PRODUCT_DIR)/sync_integration_tests<(EXECUTABLE_SUFFIX)',
- '--test-launcher-bot-mode',
- ],
- },
- }],
- ['use_x11==1', {
+ ['OS=="linux"', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -22,15 +14,15 @@
'files': [
'../testing/test_env.py',
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
],
},
}],
- ['OS=="linux"', {
+ ['OS=="linux" and use_ozone==0', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
@@ -57,6 +49,14 @@
],
},
}],
+ ['OS=="mac" or OS=="win"', {
+ 'variables': {
+ 'command': [
+ '<(PRODUCT_DIR)/sync_integration_tests<(EXECUTABLE_SUFFIX)',
+ '--test-launcher-bot-mode',
+ ],
+ },
+ }],
['OS=="mac"', {
'variables': {
'files': [
« no previous file with comments | « chrome/interactive_ui_tests.isolate ('k') | chrome/unit_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698