Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843683005: Fix a bit of C++11 in web/ (Closed)

Created:
5 years, 11 months ago by kenneth.r.christiansen
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, dcheng, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, timvolodine, vsevik+blink_chromium.org, yurys+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -77 lines) Patch
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/SuspendableScriptExecutor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/TextFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebGeolocationPermissionRequestManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 6 chunks +13 lines, -13 lines 2 comments Download
M Source/web/WebSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSocketChannelClientProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSocketImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSocketImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSpeechRecognitionResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kenneth.r.christiansen
5 years, 11 months ago (2015-01-08 12:27:05 UTC) #2
kenneth.r.christiansen
5 years, 11 months ago (2015-01-08 13:27:29 UTC) #4
Mike West
LGTM % optional nits. https://codereview.chromium.org/843683005/diff/1/Source/web/WebSearchableFormData.cpp File Source/web/WebSearchableFormData.cpp (right): https://codereview.chromium.org/843683005/diff/1/Source/web/WebSearchableFormData.cpp#newcode106 Source/web/WebSearchableFormData.cpp:106: for (WillBeHeapVector<RawPtrWillBeMember<HTMLElement>>::const_iterator i(listItems.begin()); i != ...
5 years, 11 months ago (2015-01-08 13:32:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843683005/1
5 years, 11 months ago (2015-01-08 13:34:54 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 13:47:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188043

Powered by Google App Engine
This is Rietveld 408576698