Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 843643003: Only run install-debian.wheezy.sysroot.py once during runhooks (Closed)

Created:
5 years, 11 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sysroot_download
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only run install-debian.wheezy.sysroot.py once during runhooks This script was previously run three times, once for each arch, with two of the three always being no-ops. Instead just run the script once and have the script figure out which image to download. Second attempt at landing this. First attempt caused failures on windows builders: https://codereview.chromium.org/834133003 TEST=trybots + 'gclient runhooks' locally Committed: https://crrev.com/d4eff31d57ec1be91736ba32f56dda2c8edfb195 Cr-Commit-Position: refs/heads/master@{#310753}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -78 lines) Patch
M DEPS View 1 1 chunk +1 line, -22 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 1 2 5 chunks +65 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam Clegg
The first attempt fail on the main waterfall but worked on the trybots: http://build.chromium.org/p/chromium/builders/Win/builds/27781 I ...
5 years, 11 months ago (2015-01-08 11:36:30 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-08 21:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843643003/40001
5 years, 11 months ago (2015-01-09 10:38:49 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 11:14:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 11:15:45 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4eff31d57ec1be91736ba32f56dda2c8edfb195
Cr-Commit-Position: refs/heads/master@{#310753}

Powered by Google App Engine
This is Rietveld 408576698