Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 834133003: Only run install-debian.wheezy.sysroot.py once during runhooks (Closed)

Created:
5 years, 11 months ago by Sam Clegg
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only run install-debian.wheezy.sysroot.py once during runhooks This script was previously run three times, once for each arch, with two of the three always being no-ops. Instead just run the script once and have the script figure out which image to download. TEST=trybots + 'gclient runhooks' locally Committed: https://crrev.com/711802679ce2feb228ad418dd117ae23301e5c02 Cr-Commit-Position: refs/heads/master@{#310467}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -67 lines) Patch
M DEPS View 1 1 chunk +1 line, -22 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 7 chunks +52 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 11 months ago (2015-01-07 14:04:51 UTC) #2
Lei Zhang
lgtm Keep an eye on the "official" bots and make sure they don't blow up.
5 years, 11 months ago (2015-01-07 22:45:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834133003/20001
5 years, 11 months ago (2015-01-08 10:12:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 10:23:27 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/711802679ce2feb228ad418dd117ae23301e5c02 Cr-Commit-Position: refs/heads/master@{#310467}
5 years, 11 months ago (2015-01-08 10:24:10 UTC) #7
henrika (OOO until Aug 14)
5 years, 11 months ago (2015-01-08 10:46:14 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/843683003/ by henrika@chromium.org.

The reason for reverting is: See failing gclient runhooks after this patch and
the Chrome build tree turned red (see
http://build.chromium.org/p/chromium.win/waterfall?builder=Win8%20GN for
details).

I can't find any other reason for this failure and will will try to revert..

Powered by Google App Engine
This is Rietveld 408576698